Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version detection #81

Merged
merged 9 commits into from
Feb 19, 2020

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Feb 18, 2020

Fix #46

As a side note, then this also means that I could add support for RW versions less than 6.07 again.

Edit: I forgot to mention that this is only a rough version estimation, based on if some fields exists or not.

@jontje jontje requested a review from gavanderhoorn February 18, 2020 15:50
@gavanderhoorn
Copy link
Member

As a general comment: it's a bit strange there are no fields in EGM that are populated with this information.

Would be great as an enhancement to the base EGM .proto.

@jontje
Copy link
Contributor Author

jontje commented Feb 18, 2020

As a general comment: it's a bit strange there are no fields in EGM that are populated with this information.

Agreed.

Would be great as an enhancement to the base EGM .proto.

I have already mentioned this to the EGM developers.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

include/abb_libegm/egm_base_interface.h Outdated Show resolved Hide resolved
proto/egm_wrapper.proto Outdated Show resolved Hide resolved
proto/egm_wrapper.proto Outdated Show resolved Hide resolved
src/egm_base_interface.cpp Show resolved Hide resolved
jontje and others added 2 commits February 19, 2020 10:54
@gavanderhoorn
Copy link
Member

Nice.

Thanks for iterating 👍

@gavanderhoorn gavanderhoorn merged commit 69823e7 into ros-industrial:master Feb 19, 2020
@jontje jontje deleted the add_version_detection branch February 19, 2020 14:45
@loongsunchan
Copy link

loongsunchan commented Jul 2, 2020

Hi, it's so good to see you raised this issue, and then related MR was merged. So is it possible to support RW versions less than 6.07 within the master branch? I'm not sure because the README.md is still claiming that RobotWare versions less than 6.07.01 are now incompatible with abb_libegm (due to changes in the EGM communication protocol).
@jontje @gavanderhoorn

@gavanderhoorn
Copy link
Member

@loongsunchan: #82 is still open. While it would be possible to at least detect someone is attempting to use an older version, no support for version < 6.07 is currently available.

@loongsunchan
Copy link

@gavanderhoorn
I have one with version < 6.07 and wondering is it possible to checkout to a previous branch so that I get an available driver?

@jontje
Copy link
Contributor Author

jontje commented Jul 3, 2020

I have one with version < 6.07 and wondering is it possible to checkout to a previous branch so that I get an available driver?

@loongsunchan, I recommend that you upgrade to a newer RobotWare version (it's free) but if that isn't an option, then you can roll back to an earlier version. Commit 880245b should work for you, however it will be missing some bug fixes and improvements.

@loongsunchan

This comment has been minimized.

@loongsunchan

This comment has been minimized.

@gavanderhoorn

This comment has been minimized.

@loongsunchan

This comment has been minimized.

@gavanderhoorn

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Investigate version detection of EGM protocol
3 participants