-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version detection #81
Add version detection #81
Conversation
As a general comment: it's a bit strange there are no fields in EGM that are populated with this information. Would be great as an enhancement to the base EGM |
Agreed.
I have already mentioned this to the EGM developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Co-Authored-By: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
Nice. Thanks for iterating 👍 |
Hi, it's so good to see you raised this issue, and then related MR was merged. So is it possible to support RW versions less than 6.07 within the master branch? I'm not sure because the |
@loongsunchan: #82 is still open. While it would be possible to at least detect someone is attempting to use an older version, no support for version |
@gavanderhoorn |
@loongsunchan, I recommend that you upgrade to a newer RobotWare version (it's free) but if that isn't an option, then you can roll back to an earlier version. Commit 880245b should work for you, however it will be missing some bug fixes and improvements. |
Fix #46
As a side note, then this also means that I could add support for RW versions less than
6.07
again.Edit: I forgot to mention that this is only a rough version estimation, based on if some fields exists or not.