enhancement: Adding Github action to build and push custom catalog from feature branch #1413
Conversation
…om feature branch
CFSNM
force-pushed
the
add_feature_branch_wf
branch
from
e1078bf to
9ba7d90
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-dummy-branch #1413 +/- ##
=======================================================
Coverage ? 18.91%
=======================================================
Files ? 30
Lines ? 3399
Branches ? 0
=======================================================
Hits ? 643
Misses ? 2687
Partials ? 69 ☔ View full report in Codecov by Sentry. |
| podman login -u ${{ secrets.QUAY_ID }} -p ${{ secrets.QUAY_TOKEN }} quay.io | ||
| - name: Build Feature Branch Catalog | ||
| run: | | ||
| make catalog-build -e CATALOG_IMG=${{ env.CATALOG_IMG }} -e BUNDLE_IMG=${{ env.BUNDLE_IMG }} |
There was a problem hiding this comment.
Should you either use -e or CATALOG_IMG/BUNDLE_IMG from environment command line?
| on: | ||
| push: | ||
| branches: | ||
| - "feature-**" |
There was a problem hiding this comment.
Are we really targeting subdirectories here?
| --- | ||
| name: Build and Push Feature Branch Custom Catalog | ||
| env: | ||
| BUNDLE_IMG: quay.io/${{ secrets.QUAY_ORG }}/opendatahub-operator:${GITHUB_REF##*/} |
There was a problem hiding this comment.
isnt bundle in quay.io/${{ secrets.QUAY_ORG }}/opendatahub-operator-bundle:${GITHUB_REF##*/}
| jobs: | ||
| build-and-push-feature-branch-custom-catalog: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 60 |
|
Closing this one, the change will be done in Openshift CI |
Description
This PR adds a new Github action to build and push catalog image to quay.io registry related to feature branches, in order to have the most updated catalog
https://issues.redhat.com/browse/RHOAIENG-16343
How Has This Been Tested?
This has been tested from local, and needs to be merged in order to test it using the pull_request_target kw