Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Github action to build and push custom catalog from feature branch #1396

Conversation

CFSNM
Copy link
Member

@CFSNM CFSNM commented Nov 27, 2024

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfsnm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CFSNM CFSNM force-pushed the feature-branch-push branch 7 times, most recently from bdf63e0 to aa036a0 Compare November 27, 2024 14:56
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 52.14106% with 380 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-dummy-branch@c5e6456). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/controller/actions/deploy/action_deploy.go 61.34% 95 Missing and 14 partials ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 69 Missing ⚠️
pkg/cluster/cluster_config.go 0.00% 42 Missing ⚠️
...r/actions/deploy/action_deploy_merge_deployment.go 51.38% 23 Missing and 12 partials ⚠️
...ctions/render/kustomize/action_render_manifests.go 70.78% 23 Missing and 3 partials ⚠️
pkg/controller/actions/gc/action_gc.go 71.25% 18 Missing and 5 partials ⚠️
...g/controller/actions/deploy/action_deploy_cache.go 48.14% 11 Missing and 3 partials ⚠️
pkg/controller/actions/gc/action_gc_support.go 53.84% 8 Missing and 4 partials ⚠️
.../dscinitialization/dscinitialization_controller.go 21.42% 10 Missing and 1 partial ⚠️
.../actions/deleteresource/action_delete_resources.go 73.80% 9 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature-dummy-branch    #1396   +/-   ##
=======================================================
  Coverage                        ?   26.34%           
=======================================================
  Files                           ?       65           
  Lines                           ?     5216           
  Branches                        ?        0           
=======================================================
  Hits                            ?     1374           
  Misses                          ?     3684           
  Partials                        ?      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CFSNM CFSNM marked this pull request as draft November 27, 2024 15:11
@CFSNM CFSNM force-pushed the feature-branch-push branch 3 times, most recently from d77574d to 1db47ae Compare November 27, 2024 15:55
@CFSNM CFSNM changed the title Feature branch push Adding Github action to build and push custom catalog from feature branch Nov 27, 2024
@CFSNM CFSNM force-pushed the feature-branch-push branch from 1db47ae to c92dafa Compare November 27, 2024 15:59
@CFSNM CFSNM force-pushed the feature-branch-push branch 4 times, most recently from 0d75e87 to 74a1b89 Compare November 27, 2024 16:15
@CFSNM CFSNM force-pushed the feature-branch-push branch 4 times, most recently from 5acf51d to 11d98e3 Compare November 28, 2024 10:40
@CFSNM CFSNM force-pushed the feature-branch-push branch 8 times, most recently from 2558a9e to 3d61fe7 Compare December 2, 2024 15:37
branches:
- "feature-**"
permissions:
contents: read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CFSNM , IIRC the contents have read permissions by default? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it seems to be working without the read permissions. Removing them

@CFSNM CFSNM changed the base branch from feature-operator-refactor to feature-dummy-branch December 3, 2024 08:47
@CFSNM CFSNM changed the base branch from feature-dummy-branch to feature-operator-refactor December 3, 2024 08:49
@CFSNM CFSNM force-pushed the feature-branch-push branch 12 times, most recently from fbe85f7 to 93e5fcd Compare December 3, 2024 09:40
@CFSNM CFSNM requested a review from AjayJagan December 3, 2024 09:40
@CFSNM CFSNM force-pushed the feature-branch-push branch from 93e5fcd to 6a230b2 Compare December 3, 2024 09:41
@CFSNM CFSNM force-pushed the feature-branch-push branch from 6a230b2 to 511a4c9 Compare December 3, 2024 09:44
@CFSNM
Copy link
Member Author

CFSNM commented Dec 3, 2024

Closing this one. Work continues : #1413

@CFSNM CFSNM closed this Dec 3, 2024
@CFSNM CFSNM deleted the feature-branch-push branch December 3, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants