-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Github action to build and push custom catalog from feature branch #1396
Adding Github action to build and push custom catalog from feature branch #1396
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bdf63e0
to
aa036a0
Compare
d77574d
to
1db47ae
Compare
1db47ae
to
c92dafa
Compare
0d75e87
to
74a1b89
Compare
5acf51d
to
11d98e3
Compare
2558a9e
to
3d61fe7
Compare
branches: | ||
- "feature-**" | ||
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CFSNM , IIRC the contents have read
permissions by default? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it seems to be working without the read permissions. Removing them
fbe85f7
to
93e5fcd
Compare
93e5fcd
to
6a230b2
Compare
6a230b2
to
511a4c9
Compare
Closing this one. Work continues : #1413 |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria