Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Adding Github action to build and push custom catalog from feature branch #1413

Closed
wants to merge 1 commit into from
Closed

enhancement: Adding Github action to build and push custom catalog from feature branch #1413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/feature-branch-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: Build and Push Feature Branch Custom Catalog
env:
BUNDLE_IMG: quay.io/${{ secrets.QUAY_ORG }}/opendatahub-operator:${GITHUB_REF##*/}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt bundle in quay.io/${{ secrets.QUAY_ORG }}/opendatahub-operator-bundle:${GITHUB_REF##*/}

CATALOG_IMG: quay.io/${{ secrets.QUAY_ORG }}/opendatahub-operator-catalog:${GITHUB_REF##*/}
on:
push:
branches:
- "feature-**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really targeting subdirectories here?

permissions:
pull-requests: read
checks: read
jobs:
build-and-push-feature-branch-custom-catalog:
runs-on: ubuntu-latest
timeout-minutes: 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much, 5mins enough

steps:
- name: Checkout
uses: actions/checkout@v4
- name: Login to quay.io
run: |
podman login -u ${{ secrets.QUAY_ID }} -p ${{ secrets.QUAY_TOKEN }} quay.io
- name: Build Feature Branch Catalog
run: |
make catalog-build -e CATALOG_IMG=${{ env.CATALOG_IMG }} -e BUNDLE_IMG=${{ env.BUNDLE_IMG }}
Copy link
Contributor

@ykaliuta ykaliuta Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you either use -e or CATALOG_IMG/BUNDLE_IMG from environment command line?

- name: Push Feature Branch Catalog to quay.io
run: |
make catalog-push -e CATALOG_IMG=${{ env.CATALOG_IMG }}
Loading