Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-155065 PartnerCards fallback for invalid thumbnail images #28

Merged
merged 4 commits into from
Jul 29, 2024
Merged

MWPW-155065 PartnerCards fallback for invalid thumbnail images #28

merged 4 commits into from
Jul 29, 2024

Conversation

richardhand-fortedigital
Copy link
Collaborator

@richardhand-fortedigital richardhand-fortedigital commented Jul 25, 2024 •
edited
Loading

@richardhand
MWPW-155065 PartnerCards fallback for invalid thumbnail images
410ca6c 
- checks news card background image on first updated
- replace with a hardcoded default image path
- changes the background color of the card header to prevent FOUC
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@richardhand
MWPW-155065 PartnerCards fallback for invalid thumbnail images
dd1134d 
- reverts change in default background color for thumbnails
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-155065-invalid-thumbnail-fallback July 25, 2024 15:58 Inactive
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 25, 2024 •
edited
Loading

Page Scores Audits Google
/channelpartners/drafts/dragana/announcements PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@richardhand-fortedigital richardhand-fortedigital mentioned this pull request Jul 25, 2024
Closed
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-155065-invalid-thumbnail-fallback July 25, 2024 16:22 Inactive
Ben-Zahler
Ben-Zahler approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@Ben-Zahler Ben-Zahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a tiny fix, but this looks good

@richardhand
MWPW-155065 PartnerCards fallback for invalid thumbnail images
e75ab54 
- PR feedback, use styles to read background image urls
@richardhand-fortedigital richardhand-fortedigital mentioned this pull request Jul 29, 2024
Merged
@richardhand-fortedigital richardhand-fortedigital merged commit c1a8072 into stage Jul 29, 2024
3 of 4 checks passed
@richardhand-fortedigital richardhand-fortedigital deleted the mwpw-155065-invalid-thumbnail-fallback branch July 29, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganatrajkovic draganatrajkovic draganatrajkovic approved these changes

@Ben-Zahler Ben-Zahler Ben-Zahler approved these changes

@dejanpreradovic dejanpreradovic Awaiting requested review from dejanpreradovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardhand-fortedigital @Ben-Zahler @draganatrajkovic @richardhand