Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155065 PartnerCards fallback for invalid thumbnail images #48

Merged

Conversation

- checks news card background image on first updated
- replace with a default
Copy link

aem-code-sync bot commented Jul 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (af52e4d) to head (9701383).

Files Patch % Lines
eds/components/NewsCard.js 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #48      +/-   ##
==========================================
+ Coverage   84.09%   84.18%   +0.09%     
==========================================
  Files          10       10              
  Lines        2565     2586      +21     
==========================================
+ Hits         2157     2177      +20     
- Misses        408      409       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardhand-fortedigital richardhand-fortedigital merged commit 9680317 into stage Jul 30, 2024
7 of 8 checks passed
@richardhand-fortedigital richardhand-fortedigital deleted the mwpw-155065-invalid-thumbnail-fallback branch July 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants