MWPW-155065 PartnerCards fallback for invalid thumbnail images #46
Conversation
- checks news card background image on first updated - replace with a hardcoded default (needs configuration somewhere) - changes the background color of the card header to prevent FOUC
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #46 +/- ##
==========================================
+ Coverage 84.09% 84.17% +0.07%
==========================================
Files 10 10
Lines 2565 2584 +19
==========================================
+ Hits 2157 2175 +18
- Misses 408 409 +1 ☔ View full report in Codecov by Sentry. |
| @@ -4,6 +4,9 @@ import { formatDate, getLibs } from '../scripts/utils.js'; | |||
| const miloLibs = getLibs(); | |||
| const { html, LitElement } = await import(`${miloLibs}/deps/lit-all.min.js`); | |||
|
|
|||
| // @todo - make this configurable somewhere. | |||
| const DEFAULT_BACKGROUND_IMAGE_URL = 'https://solutionpartners.stage2.adobe.com/content/dam/solution/en/images/card-collection/sample_default.png'; | |||
There was a problem hiding this comment.
open to ideas for where this configuration could live
There was a problem hiding this comment.
@richardhand ath looks good, but I think this should be a relative path. stage2.adobe.com will not work for prod
we also have a prod/non-prod switch somewhere, that could be a good choice to make this work also on milo branches
There was a problem hiding this comment.
let's continue this conversation on adobecom/dme-partners#28
|
implemented now in DME, closing here: adobecom/dme-partners#28 |
richardhand-fortedigital
deleted the
mwpw-155065-invalid-thumbnail-fallback
branch
LINKS:
Before:
After: