-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(qr-link): Age verification token field in UserData struct #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsayed
changed the title
Added new boolean field in the UserData struct to enable/disable age verification on the orb.
New boolean field in UserData struct
Dec 10, 2024
bsayed
changed the title
New boolean field in UserData struct
feat(qr-link): New boolean field in UserData struct
Dec 10, 2024
bsayed
changed the title
feat(qr-link): New boolean field in UserData struct
feat(qr-link): Age verification boolean field in UserData struct
Dec 10, 2024
bsayed
changed the title
feat(qr-link): Age verification boolean field in UserData struct
feat(qr-link): Age verification token field in UserData struct
Dec 11, 2024
…verification on the orb.
…d ona request from POP team.
bsayed
force-pushed
the
bassamsayed-support-bypass-age-verification
branch
from
December 12, 2024 05:02
884f82d
to
068750c
Compare
@@ -24,6 +24,8 @@ pub struct UserData { | |||
pub user_centric_signup: bool, | |||
/// A unique UUID that the Orb will use to send messages to the app through Orb Relay. | |||
pub orb_relay_app_id: Option<String>, | |||
/// Whether the Orb should perform the age verification. If the token exists we skip the age verification. | |||
pub bypass_age_verification_token: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a String
?
if it should be bool
, what about a rename to bypass_age_verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got my answer from
...request from POP team
karelispanagiotis
approved these changes
Dec 12, 2024
andronat
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new boolean field in the UserData struct to enable/disable age verification on the orb.