Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qr-link): Age verification token field in UserData struct #317

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

bsayed
Copy link
Contributor

@bsayed bsayed commented Dec 10, 2024

Added new boolean field in the UserData struct to enable/disable age verification on the orb.

@bsayed bsayed requested a review from andronat December 10, 2024 21:50
@bsayed bsayed changed the title Added new boolean field in the UserData struct to enable/disable age verification on the orb. New boolean field in UserData struct Dec 10, 2024
@bsayed bsayed changed the title New boolean field in UserData struct feat(qr-link): New boolean field in UserData struct Dec 10, 2024
@bsayed bsayed changed the title feat(qr-link): New boolean field in UserData struct feat(qr-link): Age verification boolean field in UserData struct Dec 10, 2024
@bsayed bsayed changed the title feat(qr-link): Age verification boolean field in UserData struct feat(qr-link): Age verification token field in UserData struct Dec 11, 2024
@bsayed bsayed force-pushed the bassamsayed-support-bypass-age-verification branch from 884f82d to 068750c Compare December 12, 2024 05:02
@@ -24,6 +24,8 @@ pub struct UserData {
pub user_centric_signup: bool,
/// A unique UUID that the Orb will use to send messages to the app through Orb Relay.
pub orb_relay_app_id: Option<String>,
/// Whether the Orb should perform the age verification. If the token exists we skip the age verification.
pub bypass_age_verification_token: Option<String>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a String?
if it should be bool, what about a rename to bypass_age_verification

Copy link
Member

@karelispanagiotis karelispanagiotis Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got my answer from

...request from POP team

@karelispanagiotis karelispanagiotis self-requested a review December 12, 2024 13:02
@andronat andronat merged commit c11dd05 into main Dec 12, 2024
13 checks passed
@andronat andronat deleted the bassamsayed-support-bypass-age-verification branch December 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants