Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize UTD message #1015

Merged
merged 3 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1014.improvements
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Changer le message d'erreur en cas de message non déchiffré.
2 changes: 1 addition & 1 deletion library/ui-strings/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1527,7 +1527,7 @@
<string name="crypto_error_withheld_unverified">Vous ne pouvez pas accéder à ce message car l’envoyeur n’a pas confiance en votre appareil</string> <!-- Tchap: Use custom string -->
<string name="crypto_error_withheld_blacklisted">Impossible d’accéder à ce message car vous avez été bloqué par l’envoyeur</string>
<string name="notice_crypto_unable_to_decrypt_friendly_desc">À cause du chiffrement de bout en bout, vous pouvez avoir besoin d’attendre l’arrivée du message de quelqu’un car les clés Tchap ne vous ont pas été correctement envoyées.</string> <!-- Tchap: Use custom string -->
<string name="notice_crypto_unable_to_decrypt_friendly">Message verrouillé : ouvrez ${app_name} sur un autre appareil pour récupérer vos messages.</string> <!-- Tchap: Use custom string -->
<string name="notice_crypto_unable_to_decrypt_friendly">Déchiffrement en cours…</string> <!-- Tchap: Use custom string -->
<string name="notice_crypto_unable_to_decrypt_final">Vous n’avez pas accès à ce message</string>
<string name="room_settings_save_success">Vous avez bien changé les paramètres du salon</string>
<string name="room_settings_topic_hint">Sujet</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
<string name="tchap_empty_room_no_permission_to_post">Votre destinataire a quitté le salon ou refusé votre invitation. Vous ne pouvez pas lui envoyer de message.</string>
<string name="tchap_discovery_section">Utilisateur trouvé</string>
<string name="tchap_login_reset_password_on">Réinitialiser le mot de passe</string>
<string name="tchap_notice_crypto_unable_to_decrypt_faq">Sinon, consultez la FAQ.</string>

<!-- tchap discussion -->
<string name="tchap_contact_external">Externe</string>
Expand Down
2 changes: 1 addition & 1 deletion library/ui-strings/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2811,7 +2811,7 @@
<string name="room_settings_set_avatar">Set avatar</string>

<string name="notice_crypto_unable_to_decrypt_final">You cannot access this message</string>
<string name="notice_crypto_unable_to_decrypt_friendly">Locked message: please open ${app_name} on another device to retrieve your messages.</string> <!-- Tchap: Use custom string -->
<string name="notice_crypto_unable_to_decrypt_friendly">Decrypting…</string> <!-- Tchap: Use custom string -->
<string name="notice_crypto_unable_to_decrypt_friendly_desc">Due to end-to-end encryption, you might need to wait for someone\'s message to arrive because the encryption keys were not properly sent to you.</string>
<string name="crypto_error_withheld_blacklisted">You cannot access this message because you have been blocked by the sender</string>
<string name="crypto_error_withheld_unverified">You cannot access this message because your session is not trusted by the sender</string>
Expand Down
1 change: 0 additions & 1 deletion library/ui-strings/src/main/res/values/strings_tchap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
<string name="tchap_empty_room_no_permission_to_post">Your recipient has left the room or has refused your invite. You cannot send him a message.</string>
<string name="tchap_discovery_section">Discovered user</string>
<string name="tchap_login_reset_password_on">Reset password</string>
<string name="tchap_notice_crypto_unable_to_decrypt_faq">Otherwise, open the FAQ.</string>

<!-- tchap discussion -->
<string name="tchap_contact_external">External</string>
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que le learnMore devrait aller à la ligne.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areox-net peux tu nous préciser si nous devons mettre le texte "en savoir plus" en dessous du texte "déchiffrement en cours" ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si ça rentre sur une ligne il peut rester sur une ligne. Mais du coup je vois pas pourquoi sur Android ça rentre et sur iOS ça va à la ligne. Des tailles de téléphone et de typp differentes probablement?

Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ class EncryptedItemFactory @Inject constructor(
else -> {
// Tchap: Add faq link in unable to decrypt error
span {
val faq = stringProvider.getString(R.string.tchap_notice_crypto_unable_to_decrypt_faq)
text = "${stringProvider.getString(R.string.notice_crypto_unable_to_decrypt_friendly)} $faq"
val learnMore = stringProvider.getString(R.string.action_learn_more)
text = "${stringProvider.getString(R.string.notice_crypto_unable_to_decrypt_friendly)} $learnMore"
.toSpannable()
.tappableMatchingText(faq, object : ClickableSpan() {
.tappableMatchingText(learnMore, object : ClickableSpan() {
override fun onClick(widget: View) {
openUrlInExternalBrowser(widget.context, TCHAP_FAQ_UTD_URL)
}
Expand Down
Loading