Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize UTD message #1015

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Harmonize UTD message #1015

merged 3 commits into from
Mar 5, 2024

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Mar 4, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#1014

Motivation and context

Screenshots / GIFs

image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested a review from NicolasBuquet March 4, 2024 21:40
@yostyle yostyle self-assigned this Mar 4, 2024
@yostyle yostyle changed the title Yostyle/harmonize utd message Harmonize utd message Mar 4, 2024
@yostyle yostyle changed the title Harmonize utd message Harmonize UTD message Mar 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que le learnMore devrait aller à la ligne.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areox-net peux tu nous préciser si nous devons mettre le texte "en savoir plus" en dessous du texte "déchiffrement en cours" ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si ça rentre sur une ligne il peut rester sur une ligne. Mais du coup je vois pas pourquoi sur Android ça rentre et sur iOS ça va à la ligne. Des tailles de téléphone et de typp differentes probablement?

@yostyle yostyle merged commit 212bf42 into develop Mar 5, 2024
14 of 15 checks passed
@yostyle yostyle deleted the yostyle/harmonize_utd_message branch March 5, 2024 10:23
@tchap-danger-bot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 56d293e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants