test: update async_no_yield test from vconnect test group
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After tarantool/tarantool#9489 is fixed, we can update the test to reflect the correct behaviour. However, we still need to test the incorrect behaviour for older versions of Tarantool to which the bugfix was not backported to. Due to tarantool/tarantool#9489, we have deadlock: either Tarantool's integration tests fail with vshard or testing against the Tarantool master version fails in vshard. Let's temporarily disable the assertion that tests against the correct behaviour in newer Tarantool versions and causes failure. Part of tarantool#456 NO_DOC=<test>
CuriousGeorgiy
force-pushed
the
gh-456-disable-test
branch
from
105e80a to
62becdd
Compare
Serpentian
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
After discussing with @Gerold103 and @sergepetrenko, it was decided to drop the test in order to avoid CI becoming red.
For now, I don't really care, how we'll disable this test for versions >= 2.11, the patch does its job, I'm ok with it.
However, when we'll enable it, it won't be enough to uncomment the line. We'll have to strictly specify versions on which this will or won't work.
E.g. with current check we say, that version 2.11.0-0 (first commit in 2.11.0) will be alright, it won't. We'll have to specify the commit number correctly. The same applies to version 3.0.0 (it will be backported there, won't it?). So, we'll have equality of csw in [2.11.0-n; 3.0.0-0] U [3.0.0-m; infinity]
Gerold103
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings an update to the test to reflect the correct behavior after tarantool/tarantool#9489 is fixed. The test against correct behavior is temporarily disabled until tarantol/tarantool#9803 is merged.
This patch needs to be merged before tarantool/tarantool#9803.
Part of #456