Skip to content

Commit

Permalink
test: update async_no_yield test from vconnect test group
Browse files Browse the repository at this point in the history
After tarantool/tarantool#9489 is fixed, we can update the test to reflect
the correct behaviour. However, we still need to test the incorrect
behaviour for older versions of Tarantool to which the bugfix was not
backported to.

Due to tarantool/tarantool#9489, we have deadlock: either Tarantool's
integration tests fail with vshard or testing against the Tarantool master
version fails in vshard. Let's temporarily disable the assertion that
tests against the correct behaviour in newer Tarantool versions and causes
failure.

Part of #456

NO_DOC=<test>
  • Loading branch information
CuriousGeorgiy committed Mar 14, 2024
1 parent 686bde3 commit 62becdd
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions test/replicaset-luatest/vconnect_test.lua
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,14 @@ test_group.test_async_no_yield = function(g)
local csw1 = fiber.self():csw()
local ret, err = rs:callrw('get_uuid', {}, opts)
local csw2 = fiber.self():csw()
-- Waiting for #456 to be fixed.
t.assert_equals(csw2, csw1 + 1)
if vutil.version_is_at_least(2, 11, 0, nil, 0, 0) then
-- Temporarily disabled until #456 is fixed.
-- t.assert_equals(csw2, csw1)
t.assert(true)
else
-- Due to tarantool/tarantool#9489 bug.
t.assert_equals(csw2, csw1 + 1)
end
t.assert_str_contains(err.name, 'VHANDSHAKE_NOT_COMPLETE')
t.assert_equals(ret, nil)
t.assert_not_equals(rs.master.conn.state, 'closed')
Expand Down

0 comments on commit 62becdd

Please sign in to comment.