Replace the daggy crate with petgraph
#448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primeos-work
commented
Jan 3, 2025
The `daggy` crate doesn't seem maintained anymore as the last commit was over three years ago [0] and there isn't really any activity since then. Daggy is already based on top of `petgraph` and described as follows: > The most prominent type is Dag - a wrapper around petgraph’s Graph > data structure, exposing a refined API targeted towards directed > acyclic graph related functionality. This means that we can switch directly to `petgraph` without too much effort. We'll loose some of the refined API, especially walking graphs via iterators, but it doesn't really matter too much as the `Acyclic` type, "a wrapper around graph types that enforces an acyclicity invariant", works well enough (just a bit less "refined"). We also already used `petgraph` directly for the `tree-of` command. This direct dependency on `petgraph` became the trigger for dropping the dependency on `daggy` since `petgraph` yanked the release of version `0.6.6` with the new release of version `0.7.0` [1] and the resulting CI failure for the `petgraph` update [2] made me take a closer look at the situation (we don't necessarily have to drop `daggy` just yet but it seems for the best given it's unclear future and the duplicated `petgraph` dependency that causes incompatibilities / build failures). [0]: https://github.com/mitchmindtree/daggy [1]: petgraph/petgraph#712 [2]: science-computing#446 Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
primeos-work
force-pushed
the
replace-daggy-with-petgraph
branch
from
571a183 to
5b04fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
daggycrate doesn't seem maintained anymore as the last commit was over three years ago 0 and there isn't really any activity since then.Daggy is already based on top of
petgraphand described as follows:This means that we can switch directly to
petgraphwithout too much effort. We'll loose some of the refined API, especially walking graphs via iterators, but it doesn't really matter too much as theAcyclictype, "a wrapper around graph types that enforces an acyclicity invariant", works well enough (just a bit less "refined").We also already used
petgraphdirectly for thetree-ofcommand. This direct dependency onpetgraphbecame the trigger for dropping the dependency ondaggysincepetgraphyanked the release of version0.6.6with the new release of version0.7.01 and the resulting CI failure for thepetgraphupdate 2 made me take a closer look at the situation (we don't necessarily have to dropdaggyjust yet but it seems for the best given it's unclear future and the duplicatedpetgraphdependency that causes incompatibilities / build failures).