Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump petgraph from 0.6.6 to 0.7.0 #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2025

Bumps petgraph from 0.6.6 to 0.7.0.

Changelog

Sourced from petgraph's changelog.

Version 0.7.0 (2024-12-31)

  • Re-released version 0.6.6 with the correct version number, as it included a major update to an exposed crate ([#664](https://github.com/petgraph/petgraph/issues/664)_).
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [petgraph](https://github.com/petgraph/petgraph) from 0.6.6 to 0.7.0.
- [Changelog](https://github.com/petgraph/petgraph/blob/master/RELEASES.rst)
- [Commits](https://github.com/petgraph/petgraph/compare/petgraph@v0.6.6...petgraph@v0.7.0)

---
updated-dependencies:
- dependency-name: petgraph
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 1, 2025
@primeos-work primeos-work self-assigned this Jan 2, 2025
primeos-work added a commit to primeos-work/butido that referenced this pull request Jan 3, 2025
The `daggy` crate doesn't seem maintained anymore as the last commit was
over three years ago [0] and there isn't really any activity since then.

Daggy is already based on top of `petgraph` and described as follows:
> The most prominent type is Dag - a wrapper around petgraph’s Graph
> data structure, exposing a refined API targeted towards directed
> acyclic graph related functionality.

This means that we can switch directly to `petgraph` without too much
effort. We'll loose some of the refined API, especially walking graphs
via iterators, but it doesn't really matter too much as the `Acyclic`
type, "a wrapper around graph types that enforces an acyclicity
invariant", works well enough (just a bit less "refined").

We also already used `petgraph` directly for the `tree-of` command.
This direct dependency on `petgraph` became the trigger for dropping the
dependency on `daggy` since `petgraph` yanked the release of version
`0.6.6` with the new release of version `0.7.0` [1] and the resulting CI
failure for the `petgraph` update [2] made me take a closer look at the
situation (we don't have to drop `daggy` yet but it seems for the best
given it's unclear future and the duplicated `petgraph` dependency).

[0]: https://github.com/mitchmindtree/daggy
[1]: petgraph/petgraph#712
[2]: science-computing#446

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
primeos-work added a commit to primeos-work/butido that referenced this pull request Jan 3, 2025
The `daggy` crate doesn't seem maintained anymore as the last commit was
over three years ago [0] and there isn't really any activity since then.

Daggy is already based on top of `petgraph` and described as follows:
> The most prominent type is Dag - a wrapper around petgraph’s Graph
> data structure, exposing a refined API targeted towards directed
> acyclic graph related functionality.

This means that we can switch directly to `petgraph` without too much
effort. We'll loose some of the refined API, especially walking graphs
via iterators, but it doesn't really matter too much as the `Acyclic`
type, "a wrapper around graph types that enforces an acyclicity
invariant", works well enough (just a bit less "refined").

We also already used `petgraph` directly for the `tree-of` command.
This direct dependency on `petgraph` became the trigger for dropping the
dependency on `daggy` since `petgraph` yanked the release of version
`0.6.6` with the new release of version `0.7.0` [1] and the resulting CI
failure for the `petgraph` update [2] made me take a closer look at the
situation (we don't necessarily have to drop `daggy` just yet but it
seems for the best given it's unclear future and the duplicated
`petgraph` dependency that causes incompatibilities / build failures).

[0]: https://github.com/mitchmindtree/daggy
[1]: petgraph/petgraph#712
[2]: science-computing#446

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
@primeos-work
Copy link
Member

I've created #448 to replace daggy with petgraph and avoid such incompatibilities.

primeos-work added a commit to primeos-work/butido that referenced this pull request Jan 3, 2025
The `daggy` crate doesn't seem maintained anymore as the last commit was
over three years ago [0] and there isn't really any activity since then.

Daggy is already based on top of `petgraph` and described as follows:
> The most prominent type is Dag - a wrapper around petgraph’s Graph
> data structure, exposing a refined API targeted towards directed
> acyclic graph related functionality.

This means that we can switch directly to `petgraph` without too much
effort. We'll loose some of the refined API, especially walking graphs
via iterators, but it doesn't really matter too much as the `Acyclic`
type, "a wrapper around graph types that enforces an acyclicity
invariant", works well enough (just a bit less "refined").

We also already used `petgraph` directly for the `tree-of` command.
This direct dependency on `petgraph` became the trigger for dropping the
dependency on `daggy` since `petgraph` yanked the release of version
`0.6.6` with the new release of version `0.7.0` [1] and the resulting CI
failure for the `petgraph` update [2] made me take a closer look at the
situation (we don't necessarily have to drop `daggy` just yet but it
seems for the best given it's unclear future and the duplicated
`petgraph` dependency that causes incompatibilities / build failures).

[0]: https://github.com/mitchmindtree/daggy
[1]: petgraph/petgraph#712
[2]: science-computing#446

Signed-off-by: Michael Weiss <michael.weiss@eviden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant