Add more environment indicators to title and navbar #3911
Conversation
StephenHulme
force-pushed
the
sh51/add-environment-indicators
branch
from
08c5d1e to
e1cdb42
Compare
| current_environment = Rails.env.to_sym | ||
| emoji = environments[current_environment] || '❓' | ||
| %> | ||
| <%= "#{emoji}:" unless Rails.env.production? %> Sequencescape : <%= controller.controller_name.capitalize %> - <%= @page_name || controller.action_name %> | ||
| </title> |
There was a problem hiding this comment.
It is changing the title text. It is putting an emoji between the favicon and the existing title. I think a neater way of doing this would be changing the favicon (logo) colour based on environment.
When there are too many tabs open, it looks like a clutter and emoji (proposed start of title) goes hidden.
There was a problem hiding this comment.
That's a good suggestion, thanks I'll look into it.
There was a problem hiding this comment.
Here are proposed favicons for:
Dev
UAT
Training
Production (current)
There was a problem hiding this comment.
Favicons now change based on the environment as above and emojis have been removed.
There was a problem hiding this comment.
- These are matching the navigation bar colours.
- They remove the clutter from browser tab buttons.
- They have simplicity compared to the emojis.
- They use the top field above twirling lines as the environment colour.
- They fill the space between white twirling lines same as the top field colour, following the same design as Production icon, to provide contrast and put the purpose in the middle as well.
- For Dev and UAT icons only, a single colour could be considered if it helps distinguishing in browser tab buttons but I think it is not necessary and against the original icon design.
Additional: Login page's login panel image could use the same pattern. [Update: alt text of them needs changing as well if we do this]
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 48d15c6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 88.3% (0.0% change). View more on Code Climate. |
Changes proposed in this pull request
Change favicon colour for different environments
Changes background colour of the navigation bar for different environments
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version