Add more environment indicators #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHulme
requested review from
harrietc52,
yoldas,
neilsycamore,
andrewsparkes and
KatyTaylor
and removed request for
harrietc52
BenTopping
reviewed
Nov 14, 2023
|
|
||
| it 'returns the apple icon path for the training environment' do | ||
| allow(Rails).to receive(:env).and_return('training') | ||
| expect(apple_icon).to eq('apple-icon-training.png') |
There was a problem hiding this comment.
Do these find the images correctly? Image name is apple-touch-icon-training.png
There was a problem hiding this comment.
I missed that, very well spotted! I haven't got a way of testing the touch icons, so they probably aren't working.
(In practise I'm using them as the large-scale masters to create the small-scale favicons.)
I'll fix them quickly now.
|
Code Climate has analyzed commit 8445c19 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.0% (0.0% change). View more on Code Climate. |
BenTopping
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Limber environment indicators to match recent changes in Sequencescape sanger/sequencescape#3911
Changes proposed in this pull request
Screenshots:
Development and any unknown environments
Staging / UAT
Training
Production
Favicons and flash banner
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version