Reverting rubocop styles to pass the tests initially #5358
Annotations
10 errors and 10 warnings
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L429
Sample manifest with tag sequences plate sample manifest valid standard upload
Failure/Error:
ActiveRecord::Base.transaction do
return false unless valid? # rubocop:todo Rails/TransactionExitStatement
return true if process_upload_and_callbacks # rubocop:todo Rails/TransactionExitStatement
# One of our post processing checks failed, something went wrong, so we
# roll everything back
raise ActiveRecord::Rollback
end
ActiveSupport::DeprecationException:
DEPRECATION WARNING: Using `return`, `break` or `throw` to exit a transaction block is
deprecated without replacement. If the `throw` came from
`Timeout.timeout(duration)`, pass an exception class as a second
argument so it doesn't use `throw` to abort its block. This results
in the transaction being committed, but in the next release of Rails
it will rollback.
(called from run! at /home/runner/work/sequencescape/sequencescape/app/models/sample_manifest/uploader.rb:31)
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L465
Sample manifest with tag sequences plate sample manifest valid cgap foreign barcodes partial upload
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L453
Sample manifest with tag sequences plate sample manifest valid cgap foreign barcodes upload
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L441
Sample manifest with tag sequences plate sample manifest valid partial upload
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L496
Sample manifest with tag sequences plate sample manifest invalid unrecognised cgap foreign barcodes validation errors
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L510
Sample manifest with tag sequences plate sample manifest invalid duplicate cgap foreign barcodes validation errors
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L479
Sample manifest with tag sequences plate sample manifest invalid no file no file
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L35
Sample manifest with tag sequences library tube sample manifest with tag sequences valid standard upload
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L47
Sample manifest with tag sequences library tube sample manifest with tag sequences valid standard reupload and override
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Run rspec tests:
spec/features/sample_manifests/uploader_for_manifests_with_tag_sequences_spec.rb#L83
Sample manifest with tag sequences library tube sample manifest with tag sequences valid cgap foreign barcodes upload
Failure/Error: let!(:user) { create :admin }
ActiveRecord::RecordInvalid:
Validation failed: Login has already been taken
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v2, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L27
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected sets attributes on the created records
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L16
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected creates two records
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/lib/record_loader/request_type_validators_loader_spec.rb#L22
RecordLoader::RequestTypeValidatorsLoader with two_entry_example selected is idempotent
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L43
PlatePurpose::AdditionalInput#state_of with ancestors with library requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L32
PlatePurpose::AdditionalInput#state_of with ancestors with no library requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L53
PlatePurpose::AdditionalInput#state_of with no ancestors with no library requests is pending
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L64
PlatePurpose::AdditionalInput#state_of with no ancestors with library requests is passed
Skipped: Temporarily skipped with xit
|
Run rspec tests:
spec/models/plate_purpose/additional_input_spec.rb#L22
PlatePurpose::AdditionalInput#state_of with no requests is pending
Skipped: Temporarily skipped with xit
|
Loading