Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-432 centralize vue component initialization #2058

Merged
merged 37 commits into from
Dec 2, 2024
Merged

Y24-432 centralize vue component initialization #2058

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f0b654e
wip: initial implementation of vue_app
seenanair Nov 6, 2024
8bf606c
wip: removed asset_comments, pool-xp-tube-panel from application.js file
seenanair Nov 6, 2024
45cff01
refactor: userId removed from required props as it is validated in a …
seenanair Nov 6, 2024
33df21a
update: Removed index files for vue components
seenanair Nov 7, 2024
f34c0ab
update(application.js): Remove all separate entry points for vue comp…
seenanair Nov 7, 2024
5bde5bb
Update PoolXPTubeSubmitPanel.vue
seenanair Nov 7, 2024
56c1d1b
refactor(vue_app.js): Add new components and update existing ones
seenanair Nov 7, 2024
7d7f8cf
format: prettier and lint updates
seenanair Nov 7, 2024
3d0896d
Delete index.js
seenanair Nov 7, 2024
948f922
update: documentation and other minor updates
seenanair Nov 8, 2024
880c157
unit tests for vue_app.js added
seenanair Nov 8, 2024
672d98e
format: prettier and lint updates
seenanair Nov 8, 2024
a6bb1ff
refactor(FileList): Refactor file list component to handle click even…
seenanair Nov 11, 2024
7fec971
refactor : rename vue props to match with the dataset variables /
seenanair Nov 11, 2024
48749d1
Refactor vue_app.js to generalise the component rendering
seenanair Nov 11, 2024
f338adc
prettier updates
seenanair Nov 11, 2024
3cf9eff
refactor : standardise asset-comments components to use the generic s…
seenanair Nov 12, 2024
cc016d3
Merge branch 'develop' into y24-432-centralize-vue-component-initiali…
seenanair Nov 18, 2024
39dd51e
refactor: fix comments not loading issue
seenanair Nov 18, 2024
d6b2d55
refactor: removing dependency of asset comment components using eventbus
seenanair Nov 19, 2024
b97c90f
feature(comment-store-helper): Adds helper utilities to manage the co…
seenanair Nov 20, 2024
027d046
update(comment-store): Emits an eventBus event when a new comment is …
seenanair Nov 20, 2024
1522351
clean up
seenanair Nov 20, 2024
3b6df22
refactor(asset-comment-componentd): updated to use comment store crea…
seenanair Nov 20, 2024
bdfaf2c
tests: updates for comment store refactoring
seenanair Nov 20, 2024
b68898a
Update vue_app.js
seenanair Nov 20, 2024
7650e99
update count_badge to allow data attributes to be passed as props
seenanair Nov 20, 2024
6ad3d69
update(tube.html.erb): pass props to asset-comments-counter component
seenanair Nov 20, 2024
6c7c59c
renaming file
seenanair Nov 20, 2024
9466196
updates
seenanair Nov 20, 2024
ed4e91f
Merge branch 'develop' into y24-432-centralize-vue-component-initiali…
seenanair Nov 21, 2024
19096e5
Revert "Merge branch 'develop' into y24-432-centralize-vue-component-…
seenanair Nov 21, 2024
2a3f1fc
Reapply "Merge branch 'develop' into y24-432-centralize-vue-component…
seenanair Nov 21, 2024
6ae6ca7
Fixed errors while resolving merge conflicts
seenanair Nov 21, 2024
aaf4457
review comment update
seenanair Nov 21, 2024
cf8b9c0
Merge branch 'develop' into y24-432-centralize-vue-component-initiali…
seenanair Nov 26, 2024
4102bb0
Merge branch 'develop' into y24-432-centralize-vue-component-initiali…
seenanair Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/frontend/entrypoints/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,7 @@
import '@/javascript/lib/array_fill_polyfill.js'

// Currently setting up each component as its own mini vue app.
import '@/javascript/asset-comments/index.js'
import '@/javascript/custom-tagged-plate/index.js'
import '@/javascript/file-list/index.js'
import '@/javascript/labware-custom-metadata/index.js'
import '@/javascript/multi-stamp-tubes/index.js'
import '@/javascript/multi-stamp/index.js'
import '@/javascript/qc-information/index.js'
import '@/javascript/tubes-to-rack/index.js'
import '@/javascript/validate-paired-tubes/index.js'
import '@/javascript/pool-xp-tube-panel/index.js'
import '@/javascript/vue_app.js'

Check warning on line 57 in app/frontend/entrypoints/application.js

View check run for this annotation

Codecov / codecov/patch

app/frontend/entrypoints/application.js#L57 

Added line #L57 was not covered by tests

// Load simple javascript files
import '@/javascript/plain-javascript/page-reloader.js'
Expand Down
94 changes: 0 additions & 94 deletions app/frontend/javascript/asset-comments/index.js
View file
Open in desktop

This file was deleted.

60 changes: 0 additions & 60 deletions app/frontend/javascript/custom-tagged-plate/index.js
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions app/frontend/javascript/file-list/index.js
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions app/frontend/javascript/labware-custom-metadata/index.js
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions app/frontend/javascript/multi-stamp-tubes/index.js
View file
Open in desktop

This file was deleted.

Loading
Loading