-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-432 centralize vue component initialization #2058
Y24-432 centralize vue component initialization #2058
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2058 +/- ##
===========================================
+ Coverage 78.09% 80.43% +2.34%
===========================================
Files 477 471 -6
Lines 18066 17932 -134
Branches 262 268 +6
===========================================
+ Hits 14109 14424 +315
+ Misses 3955 3506 -449
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice bit of refactoring 👌
Let me know if you want to go over the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
I don't know how to test this manually but I am assuming you have and I reckon the int suite will cover most of the use cases.
That’s something I’m also a bit concerned about. I hope the integration suite covers most of it, and I’ll also ask the team if there are any better ways to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good - thanks for the improvements 🚀
…mmentFactory instances to be used across AssetComment components
…ted by utility functions and to use event bus
Nice work, I like the direction this is taking @seenanair! I see you've found the eventBus too, hopefully we can eventually get rid of all the script tags 🤞 |
Thanks @StephenHulme for the review. 🙏 This would be a great case for proper store management, but that felt like a big step right now. So, I just used the event bus since it was already there and working fine. |
…-initialization" This reverts commit 19096e5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, changes look sensible. Quite difficult to wrap my head around the store but I think it looks ok.
Closes #2033
Changes proposed in this pull request
Additional Notes
There is potential to globally register other shared components. However, some of these components are currently registered with different names across the application. A major refactor would be needed to unify these, which we recommend handling in a separate story to avoid an overly complex PR.
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version