Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Testing kit #962

Merged
merged 56 commits into from
Sep 16, 2024
Merged

feat: Testing kit #962

merged 56 commits into from
Sep 16, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Aug 27, 2024 •
edited
Loading

What it solves

Resolves #943

How this PR fixes it

We are adding a new package testing-kit

  • Moved the hardhat configuration, contracts and helpers to the common package
  • Generating a bin script for execute the tests in the pipeline or on local (Currently not working in the pipes bacause its not being generated in the target package .bin directory. Works locally. Perhaps because the package is not published?)
  • Moved the scripts related to the setupTests function to the testing-kit
  • Update protocol-kit and api-kit to use the new package. The hardhat configuration and deps are being removed from the target packages

@yagopv yagopv marked this pull request as ready for review August 28, 2024 14:51
@yagopv yagopv marked this pull request as draft August 28, 2024 14:51
@yagopv yagopv linked an issue Aug 30, 2024 that may be closed by this pull request
[SDK Refactor] New top level package testing-kit #943
Closed
@yagopv yagopv marked this pull request as ready for review August 30, 2024 10:56
@dasanra dasanra changed the base branch from passkey-support-viem to development September 11, 2024 14:58
@dasanra dasanra changed the base branch from passkey-support-viem to development September 11, 2024 15:13
@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10883725046

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.664%
Totals Coverage Status
Change from base Build 10883255908: 0.0%
Covered Lines: 752
Relevant Lines: 922
💛 - Coveralls

dasanra
dasanra reviewed Sep 13, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
yagopv and others added 2 commits September 13, 2024 09:41
@yagopv @dasanra
Update package.json
9f93937 
Co-authored-by: Daniel <25051234+dasanra@users.noreply.github.com>
@dasanra
chore: remove unnecessary await
7bf8f0d
@yagopv yagopv merged commit 0d03508 into development Sep 16, 2024
20 checks passed
@yagopv yagopv deleted the testing-kit branch September 16, 2024 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DaniSomoza DaniSomoza DaniSomoza approved these changes

@dasanra dasanra dasanra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK Refactor] New top level package testing-kit
4 participants
@yagopv @coveralls @dasanra @DaniSomoza