Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Refactor] New top level package testing-kit #943

Closed
dasanra opened this issue Aug 14, 2024 · 0 comments · Fixed by #962
Closed

[SDK Refactor] New top level package testing-kit #943

dasanra opened this issue Aug 14, 2024 · 0 comments · Fixed by #962
Assignees

Comments

@dasanra
Copy link
Collaborator

dasanra commented Aug 14, 2024

Context / issue

We have code repetition for testing. Between the protocol-kit, api-kit, and relay-kit, we share some common utilities that can be extracted into a shared package

Proposed solution

Create a new testing-kit package. This package should include:

  • hardhat configuration
  • Contract deployments
  • Common utils

This package allows us to remove code from the repository and concentrate the testing utilities in one place. This approach helps avoid errors and makes it easier to kickstart new packages.

Additional context

Research document

@dasanra dasanra changed the title [SDK Refactoring] New top level package testing-kit [SDK Refactor] New top level package testing-kit Aug 14, 2024
@yagopv yagopv self-assigned this Aug 22, 2024
@yagopv yagopv linked a pull request Aug 30, 2024 that will close this issue
@yagopv yagopv closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants