Map domainHash/messageHash to MULTISIG transactions and messages
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
changed the title
domainHash/messageHash to detailedExecutionInfo of MULTISIG transactionsdomainHash/messageHash to MULTISIG transactions and messages
iamacook
commented
Dec 9, 2024
Comment on lines
+625
to
+631
| it('these tests should cover up to the current version', () => { | ||
| const deployment = getSafeL2SingletonDeployment(); | ||
|
|
||
| expect(DOMAIN_TYPEHASH_NEW_VERSIONS.at(-1)).toBe(deployment?.version); | ||
| expect(SAFE_TX_TYPEHASH_NEW_VERSIONS.at(-1)).toBe(deployment?.version); | ||
| expect(SAFE_MESSAGE_TYPEHASH_VERSIONS.at(-1)).toBe(deployment?.version); | ||
| }); |
There was a problem hiding this comment.
I added this to ensure we check new hashes match, should the typehashes be altered.
3 tasks
…G` transactions
iamacook
force-pushed
the
domain-message-hashes
branch
from
bb07f81 to
1a9c559
Compare
PooyaRaki
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The hashes of an EIP-712 domain/message can be used to verify the legitimacy of a transaction. On the Web interface, these two values are calculated dynamically for each transaction/message.
This calculates/maps a new
typedData, containingdomainHashandmessageHashto thedetailedExecutionInfoofMULTISIGtransactions and messages, allowing the client to render it directly.Note: messages can only be initially proposed with a signature so we need take into consideration whether it influences the viability of this.
Changes
TypedDataMapperfor dynamically calculatingtypedDatahashes.typedDataproperties toMessageandMultisigExecutionDetailsentities.