feat: show message and domain hash for off-chain msgs #4399
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1009.82 KB (🟡 +90 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Three Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps/open |
55.18 KB (🟡 +5 B) |
1.04 MB |
/transactions/messages |
39.21 KB (🟡 +6 B) |
1.02 MB |
/transactions/msg |
29.54 KB (🟡 +6 B) |
1.01 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1573 tests passing in 208 suites. Report generated by 🧪jest coverage report action from 7bd56fa |
| .toUpperCase()}` | ||
| const messageHash = safeTxData | ||
| ? TypedDataEncoder.hashStruct('SafeTx', { SafeTx: getEip712TxTypes(safeVersion).SafeTx }, safeTxData) | ||
| ? `0x${TypedDataEncoder.hashStruct('SafeTx', { SafeTx: getEip712TxTypes(safeVersion).SafeTx }, safeTxData) | ||
| .slice(2) | ||
| .toUpperCase()}` |
There was a problem hiding this comment.
Nit: I'd add a comment why this is in uppercase for future reference.
| hashValue: string | ||
| capitalize?: boolean | ||
| }) => { | ||
| const hash = capitalize ? `0x${hashValue.slice(2).toUpperCase()}` : hashValue |
There was a problem hiding this comment.
I'll leave it up to you, but we could create a helper to capitalise hex considering this is the third occurance.
Screen.Recording.2024-10-24.at.21.04.31.mov |
There are many things called message hash / safe message hash here sadly. Are you sure you were comparing the message hash with what ledger displays? For me they match. |
|
@liliya-soroka please get back to us on this one. This PR only adds new fields so unlikely to break anything else. |
|
The both issues are still existing for me |
|
Superseeded by #4687. |
What it solves
Resolves #4391
How this PR fixes it
Adds two fields to off-chain msgs:
Also makes those hashes always upper case to be easier to compare with what e.g. ledger displays
How to test it
Screenshots
Checklist