Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goal pose stamp (backport #4854) #4855

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 15, 2025

Follow-up on #4822

Description of contribution in a few bullet points

  • There was a bug in the previous PR: the MPPI critics goal pose now uses stamp from global_path, which gets outdated by the TF buffer, and then fails to transform the goal pose.
  • This doesn't come up if the plan is replanned frequently.
  • As a solution, this PR uses the robot_pose.stamp, which gets updated frequently.

Description of documentation updates required from your changes

  • None required

Description of how this change was tested

  • In a custom simulation and on real robot, on the humble branch.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #4854 done by [Mergify](https://mergify.com).

Signed-off-by: redvinaa <redvinaa@gmail.com>
(cherry picked from commit 694a222)
Copy link
Contributor Author

mergify bot commented Jan 15, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 65eab41 into jazzy Jan 15, 2025
6 of 8 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4854 branch January 15, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants