Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #57: rename RSI parameters to clarify what they configure #63

Conversation

gavanderhoorn
Copy link
Member

As per subject.

@gavanderhoorn
Copy link
Member Author

Discussed in #57.

@BrettHemes
Copy link
Member

+1

@gavanderhoorn
Copy link
Member Author

Thanks for your +1 @BrettHemes :).

@bj0rkedal: would you want to update #54 after this is merged, to use the new parameter names?

@gavanderhoorn gavanderhoorn force-pushed the issue57_rsi_param_names branch from 4214299 to cf26f02 Compare August 30, 2016 10:39
@gavanderhoorn gavanderhoorn merged commit f9224e4 into ros-industrial:indigo-devel Aug 30, 2016
@gavanderhoorn gavanderhoorn deleted the issue57_rsi_param_names branch August 30, 2016 11:04
gavanderhoorn added a commit to gavanderhoorn/kuka_experimental that referenced this pull request Aug 30, 2016
bj0rkedal pushed a commit to bj0rkedal/kuka_experimental that referenced this pull request Aug 30, 2016
@bj0rkedal
Copy link
Contributor

@gavanderhoorn: Your PR has now been merged. Sorry for my inactivity, I've been quite busy lately. I've also given @tingelst access to my repository in case I don't manage to continuously follow up the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants