-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Platform release process for LTS regular release cadence #176
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package io.quarkus.bot.release; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.aggregator.ArgumentsAccessor; | ||
import org.junit.jupiter.params.provider.CsvSource; | ||
|
||
import io.quarkus.bot.release.util.Branches; | ||
|
||
public class ReleaseInformationTest { | ||
|
||
@ParameterizedTest | ||
// version,branch,qualifier,firstFinal,expectedResult | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm trying to wrap my head around what this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would deserve a (JavaDoc) comment in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes exactly. Fair point about needing more Javadoc, I'll do that in another PR. |
||
@CsvSource({ "3.6.0.CR1,3.6,CR1,false,false", | ||
"3.8.2,3.8,,false,false", | ||
"3.15.0.CR1,3.15,CR1,false,false", | ||
"3.15.0,3.15,,true,false", | ||
"3.15.1,3.15,,true,false", | ||
"3.15.2,3.15,,false,true", | ||
"3.16.2,3.16,,false,false", | ||
"3.20.0,3.20,,true,false", | ||
"3.20.1,3.20,,false,true"}) | ||
public void testIsLtsMaintenanceReleaseWithRegularReleaseCadence(ArgumentsAccessor argumentsAccessor) { | ||
String version = argumentsAccessor.getString(0); | ||
String branch = argumentsAccessor.getString(1); | ||
String qualifier = argumentsAccessor.getString(2); | ||
boolean firstFinal = argumentsAccessor.getBoolean(3); | ||
boolean expectedResult = argumentsAccessor.getBoolean(4); | ||
|
||
ReleaseInformation releaseInformation = new ReleaseInformation(version, branch, Branches.MAIN, qualifier, false, firstFinal, false); | ||
assertThat(releaseInformation.isLtsMaintenanceReleaseWithRegularReleaseCadence()).as("Version %s", releaseInformation.getVersion()).isEqualTo(expectedResult); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was unused so I thought I might as well remove it.