Adjust Platform release process for LTS regular release cadence #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Jan 8, 2025
Comment on lines
-105
to
-113
| @JsonIgnore | ||
| public boolean isFirstMicroMaintenanceRelease() { | ||
| if (version == null) { | ||
| throw new IllegalStateException("Unable to know if the version is the first micro maintenance at this stage"); | ||
| } | ||
|
|
||
| return Versions.isFirstMicroMaintenanceRelease(version); | ||
| } | ||
|
|
There was a problem hiding this comment.
This one was unused so I thought I might as well remove it.
jmartisk
reviewed
Jan 8, 2025
jmartisk
reviewed
Jan 8, 2025
| public class ReleaseInformationTest { | ||
|
|
||
| @ParameterizedTest | ||
| // version,branch,qualifier,firstFinal,expectedResult |
There was a problem hiding this comment.
I'm trying to wrap my head around what this firstFinal means. IIUC, it means that either the version ends with .0, or it ends with .1 but there is no corresponding .0 (because the original release failed or something)?
There was a problem hiding this comment.
I think this would deserve a (JavaDoc) comment in the ReleaseInformation class
There was a problem hiding this comment.
Yes exactly.
Fair point about needing more Javadoc, I'll do that in another PR.
Chances are we will have to tune things a lot, thus why I decided to not be smart by combining this with existing corner cases.
gsmet
force-pushed
the
new-lts-release-process
branch
from
7201f0d to
d6abd4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chances are we will have to tune things a lot, thus why I decided to not be smart by combining this with existing corner cases.
So the idea here is that for LTS micro versions, we will also have to wait a week between core and platform (at least for now - things might be refined along the way, we will adjust accordingly).
This doesn't really change the scripts or anything, just the instructions you have to follow for the Platform step (it's the only one that still requires manual operations).