-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Quarkiverse Docs from main README #493
Conversation
…nd return-response-objects.adoc
…nd return-response-objects.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! Many thanks!! Can you also update the README to point people to the quarkiverse docs then? :D
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
@ricardozanini I removed all documentation from README and referenced the future link in http://docs.quarkiverse.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @luanbrdev. Thank you!
Just one detail: Your branch is 7 commits behind the main
branch. So, probably the documentation is outdated in your branch.
Comparing your branch with main, we can see that there's only one commit missing from your branch that changes README.md. Can you please add the new documentation from that commit to this branch?
Also, I have one question: you mentioned you referenced the future link in http://docs.quarkiverse.io/. I don't see it there. Did you send a PR? If so, can you link the PR here, please?
@hbelmiro I'm sorry about that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini sure, here are the workflows you can use for that: |
@gastaldi it's just a matter of incorporating those workflows here? :D |
Basically yes, you need a |
@gastaldi I can apply for a token, but I don't have permission to add secrets in this repo. Can you add it? |
@ricardozanini I gave you admin access to this repo. Enjoy :) |
Actually, |
@luanbrdev can you please incorporate these workflows into this PR? If the SURGE token won't work, I can set it up here. |
If I remember correctly, the SURGE_TOKEN will only work when the workflow is already in main, so I'm afraid this needs to be done in a separate PR |
Also maybe this could be more PR-friendly: |
@luanbrdev can you do it too? So we open a different PR just to set the previews and rebase this one to see your work live! ❤️ |
@luanbrdev can you rebase? |
🎊 PR Preview 66d8b42 has been successfully built and deployed to https://quarkus-openapi-generator-preview-pr-493 |
@luanbrdev it's looking great! https://quarkus-openapi-generator-preview-pr-493.surge.sh And it seems the GHA worked too! I'll take a look at why the comment broke the URL, thou. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb job, @luanbrdev we really appreciate your effort.
@gastaldi after merging this commit, our docs will be automatically uploaded to https://docs.quarkiverse.io/index/explore/index.html ? 👯 |
@ricardozanini you need to add an entry to the https://github.com/quarkiverse/quarkiverse-docs repository. See: https://hub.quarkiverse.io/checklist/#register-the-extension-documentation-in-the-quarkiverse-docs |
@all-contributors please add @luanbrdev for docs |
I've put up a pull request to add @luanbrdev! 🎉 |
Hey there! I'm trying to help with the issue: #213
So, I'm new here and it's my first time editing Asciidoc docs. I did a copy and paste of the information present on readme in main branch. If these implementation wasn't what is expected, let me know.