Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Quarkiverse Docs from main README #493

Merged
merged 16 commits into from
Oct 25, 2023

Conversation

luanbrdev
Copy link
Contributor

Hey there! I'm trying to help with the issue: #213

So, I'm new here and it's my first time editing Asciidoc docs. I did a copy and paste of the information present on readme in main branch. If these implementation wasn't what is expected, let me know.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! Many thanks!! Can you also update the README to point people to the quarkiverse docs then? :D

@luanbrdev
Copy link
Contributor Author

@ricardozanini I removed all documentation from README and referenced the future link in http://docs.quarkiverse.io/

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @luanbrdev. Thank you!

Just one detail: Your branch is 7 commits behind the main branch. So, probably the documentation is outdated in your branch.
Comparing your branch with main, we can see that there's only one commit missing from your branch that changes README.md. Can you please add the new documentation from that commit to this branch?

Also, I have one question: you mentioned you referenced the future link in http://docs.quarkiverse.io/. I don't see it there. Did you send a PR? If so, can you link the PR here, please?

@luanbrdev luanbrdev marked this pull request as draft September 25, 2023 02:41
@luanbrdev luanbrdev marked this pull request as ready for review September 25, 2023 02:59
README.md Show resolved Hide resolved
@luanbrdev
Copy link
Contributor Author

Great work @luanbrdev. Thank you!

Just one detail: Your branch is 7 commits behind the main branch. So, probably the documentation is outdated in your branch. Comparing your branch with main, we can see that there's only one commit missing from your branch that changes README.md. Can you please add the new documentation from that commit to this branch?

Also, I have one question: you mentioned you referenced the future link in http://docs.quarkiverse.io/. I don't see it there. Did you send a PR? If so, can you link the PR here, please?

Great work @luanbrdev. Thank you!

Just one detail: Your branch is 7 commits behind the main branch. So, probably the documentation is outdated in your branch. Comparing your branch with main, we can see that there's only one commit missing from your branch that changes README.md. Can you please add the new documentation from that commit to this branch?

Also, I have one question: you mentioned you referenced the future link in http://docs.quarkiverse.io/. I don't see it there. Did you send a PR? If so, can you link the PR here, please?

@hbelmiro I'm sorry about that!
I'm not used to the fork approach and was wrong about my understanding of how 'pull' would work in my copy.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro @gastaldi do you know if we can have a preview of this PR on the website? 🤔

@ricardozanini
Copy link
Member

@gastaldi it's just a matter of incorporating those workflows here? :D

@gastaldi
Copy link
Member

Basically yes, you need a SURGE_TOKEN secret too. See https://surge.sh/help/integrating-with-circleci

@ricardozanini
Copy link
Member

@gastaldi I can apply for a token, but I don't have permission to add secrets in this repo. Can you add it?

@gastaldi
Copy link
Member

@ricardozanini I gave you admin access to this repo. Enjoy :)

@gastaldi
Copy link
Member

gastaldi commented Sep 25, 2023

Actually, SURGE_TOKEN is already defined as an Organization secret, so you should be all set. I created quarkiverse/quarkiverse-devops#184 to make you an admin to this repo if you still need it

@ricardozanini
Copy link
Member

@luanbrdev can you please incorporate these workflows into this PR? If the SURGE token won't work, I can set it up here.

@gastaldi
Copy link
Member

If I remember correctly, the SURGE_TOKEN will only work when the workflow is already in main, so I'm afraid this needs to be done in a separate PR

@gastaldi
Copy link
Member

gastaldi commented Sep 25, 2023

@ricardozanini
Copy link
Member

If I remember correctly, the SURGE_TOKEN will only work when the workflow is already in main, so I'm afraid this needs to be done in a separate PR

@luanbrdev can you do it too? So we open a different PR just to set the previews and rebase this one to see your work live! ❤️

@luanbrdev luanbrdev mentioned this pull request Oct 3, 2023
@ricardozanini
Copy link
Member

@luanbrdev can you rebase?

@luanbrdev luanbrdev marked this pull request as draft October 24, 2023 03:46
@github-actions
Copy link
Contributor

🎊 PR Preview 66d8b42 has been successfully built and deployed to https://quarkus-openapi-generator-preview-pr-493
.surge.sh

@ricardozanini
Copy link
Member

ricardozanini commented Oct 24, 2023

@luanbrdev it's looking great! https://quarkus-openapi-generator-preview-pr-493.surge.sh

And it seems the GHA worked too! I'll take a look at why the comment broke the URL, thou.

@ricardozanini ricardozanini linked an issue Oct 24, 2023 that may be closed by this pull request
@luanbrdev luanbrdev marked this pull request as ready for review October 25, 2023 03:43
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb job, @luanbrdev we really appreciate your effort.

@ricardozanini
Copy link
Member

@gastaldi after merging this commit, our docs will be automatically uploaded to https://docs.quarkiverse.io/index/explore/index.html ? 👯

@gastaldi
Copy link
Member

@ricardozanini you need to add an entry to the https://github.com/quarkiverse/quarkiverse-docs repository.

See: https://hub.quarkiverse.io/checklist/#register-the-extension-documentation-in-the-quarkiverse-docs

@ricardozanini ricardozanini changed the title Update docs Migrate to Quarkiverse Docs from main README Oct 25, 2023
@ricardozanini
Copy link
Member

@all-contributors please add @luanbrdev for docs

@allcontributors
Copy link
Contributor

@ricardozanini

I've put up a pull request to add @luanbrdev! 🎉

@ricardozanini ricardozanini merged commit 920522a into quarkiverse:main Oct 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate README.md to quarkiverse-docs
5 participants