-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions to preview docs #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing we need to change is the website URL to not clash with Quarkus main.
I think we need to get to a common sense to have this feature for all Quarkiverse extensions. I have opened quarkusio/quarkus#36289 to investigate this. |
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Sounds nice! Have you run it locally and were able to generate the website? |
Hey @ricardozanini, how are you? About the actions, I could not run completely, what I did was, I executed the job "build" using (nektos/act) and added one step before Publishing directory for PR preview that printed all files in directory /docs/target/generated-docs/ and the index.html was generated. I think that it's working, but I could not run completely. About jobs, preview and preview_teardown I only followed the example, but I not executed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys, |
Hi @ricardozanini, @gastaldi, @hbelmiro. How are you guys? |
I'm merging this now, then you can rebase your other PR to see if we can get this preview going on! |
After #511, CI is failing when merging a PR. See: https://github.com/quarkiverse/quarkus-openapi-generator/actions/runs/6811912710
Hey guys, how are you?
@gastaldi, @ricardozanini
Like we talk in conversation PR #493, I'm trying to add the actions to run the preview. But I don't know like test and I'm not sure if it's the correct way.