Support Art direction with custom ArtDirectionImage component #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
switchnollie
changed the title
ArtDirectedImage componentArtDirectionImage component
switchnollie
changed the title
ArtDirectionImage component
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de> on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de> on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de> on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de> on-behalf-of: @porscheofficial <open_source_office@porsche.de>
|
@switchnollie I merged the CCB story into this branch and upgraded all dependencies (including the switch to the Contentlayer2 fork by @timlrx). Can you please add a hero image for the CCB story optimized for mobile devices :) ? Thank you for adding this great feature! |
|
@switchnollie Shall we pick up the work on this PR again? |
|
Hey @itrich, unfortunately I'm currently completely covered with project work.. I'll let you know if I have some more capacity in the next PI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
In order to avoid cut-off hero images that are not useful on narrow screens, we need a way to support different images per viewport size. This implementation uses the Porsche Design System Breakpoints as flexible options to provide separate images per viewport width.
It does currently not work with the
next-image-export-optimizersince the library does currently not support thegetImagePropsfeature for image loading.✅ Checks