Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-dependencies #51

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

upgrade-dependencies #51

wants to merge 9 commits into from

Conversation

MarcelKnobelsdorf
Copy link
Contributor

Closes #

πŸ“‘ Description

βœ… Checks

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
porscheofficial-github-io βœ… Ready (Inspect) Visit Preview Dec 12, 2024 3:32pm
porscheofficial-open-source-platform βœ… Ready (Inspect) Visit Preview Dec 12, 2024 3:32pm

@itrich
Copy link
Member

itrich commented Dec 3, 2024

In PR #47 I migrated from the unmaintained Contentlayer package to the active fork Contentlayer2. Can we maybe cherry-pick these changes into this branch? I think the art-direction feature will take more time, so I'll propose to have the dependency changes in this branch. What do you think? @switchnollie @MarcelKnobelsdorf

Copy link

vercel bot commented Dec 3, 2024

You must have Developer access to commit code to porschedigital on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link
Member

@itrich itrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also took the chance to upgrade the GitHub Pages Deploy actions as the old versions will be soon deprecated.

Copy link
Member

@itrich itrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent upgrade to PDS 3.22.1 changed the visual style of the flyout menu. The theme of the subpanel on the flyout menu changed as well as the overall style for the "Further Stories" section
image

Will you have a look into these two issues or shall we split them? I'm happy to contribute to this PR!

Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de>
on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de>
on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Signed-off-by: Eduard Itrich <eduard.itrich@porsche.de>
on-behalf-of: @porscheofficial <open_source_office@porsche.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants