Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 chore: doc comment the need to keep using blang for version ranges #1600

Merged
merged 1 commit into from
Jan 17, 2025
+5 −0
Merged

📖 chore: doc comment the need to keep using blang for version ranges #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/catalogmetadata/filter/successors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ func legacySuccessor(installedBundle ocv1.BundleMetadata, channels ...declcfg.Ch
}
}
if candidateBundleEntry.SkipRange != "" {
// There are differences between how "github.com/blang/semver/v4" and "github.com/Masterminds/semver/v3"
// handle version ranges. OLM v0 used blang and there might still be registry+v1 bundles that rely
// on those specific differences. Because OLM v1 supports registry+v1 bundles,
// blang needs to be kept alongside any other semver lib for range handling.
// see: https://github.com/operator-framework/operator-controller/pull/1565#issuecomment-2586455768
skipRange, err := bsemver.ParseRange(candidateBundleEntry.SkipRange)
if err == nil && skipRange(installedBundleVersion) {
return true
Expand Down
Loading