-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 chore: doc comment the need to keep using blang for version ranges #1600
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
+ Coverage 66.69% 66.75% +0.05%
==========================================
Files 57 57
Lines 4588 4593 +5
==========================================
+ Hits 3060 3066 +6
+ Misses 1303 1302 -1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 thank you!
/hold Hi @azych and @perdasilva Sorry, I remove this one from the Queue. Just a small note before we proceed: We won't be able to fully support the registry+v1 bundles due to fundamental differences in concepts and design choices. We've outlined the primary limitations in detail here: OLMv1 Limitations. So we cannot add |
Would |
e0647c9
to
1de864f
Compare
PR should be good to go, can you remove the hold and merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @azych
I would prefer if we added support for a "superset of" as suggested by @perdasilva, since it seems more accurate and aligns with the terminology we use in the documentation and other places.
That said, since we're no longer claiming full support for OLM v1 here, I’m okay with the current approach.
Just to share, the registry-v1 for OLM v1 is, in some way, deprecated. Until we are able to move with the Roadmap, it will remain, but we’re still moving forward in directions like adopting HelmChart. There’s a possibility of designing a registry-v2 in the future. This new design would aim to address the issues identified with registry-v1 and be more suited for OLM v1.
/lgtm
/approve
@camilamacedo86 it looks like there is still a hold in place for this, shouldn't it be removed?
Just to clarify - @perdasilva proposed inclusion of "sub-set", not a superset and I provided my reasoning about why I chose not to go with it here: #1600 (comment) |
/hold cancel |
1de864f
to
e562d1f
Compare
New changes are detected. LGTM label has been removed. |
Adds doc comment about the need to keep using
github.com/blang/semver
library for handling version ranges.Follow up from #1565
Reviewer Checklist