fscryptctl: add new package #25716
+62
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| include $(TOPDIR)/rules.mk | ||
|
|
||
| PKG_NAME:=fscryptctl | ||
| PKG_VERSION:=1.2.0 | ||
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://codeload.github.com/google/$(PKG_NAME)/tar.gz/v$(PKG_VERSION)? | ||
|
There was a problem hiding this comment. Is the trailing There was a problem hiding this comment. I agree with #25706 (comment), better not use the variable in the URL |
||
| PKG_HASH:=192e25733006b05592fd87038a3a51a014db22f462ce0b24d47c30e66d03ea2c | ||
|
|
||
| PKG_LICENSE:=Apache | ||
|
There was a problem hiding this comment.
|
||
| PKG_LICENSE_FILES:=LICENSE | ||
| PKG_CPE_ID:=cpe:/a:google:fscryptctl | ||
|
There was a problem hiding this comment. Where did you get this CPE Id from? I cannot find it at https://nvd.nist.gov/products/cpe/search |
||
| PKG_MAINTAINER:=John Audia <therealgraysky@proton.me> | ||
|
|
||
| include $(INCLUDE_DIR)/package.mk | ||
|
|
||
| define Package/fscryptctl | ||
| SECTION:=utils | ||
| CATEGORY:=Utilities | ||
| SUBMENU:=Encryption | ||
| TITLE:=A tool that handles keys and manages policies for Linux filesystem encryption | ||
| URL:='https://github.com/google/fscryptctl' | ||
|
|
||
| endef | ||
|
|
||
| define Package/fscryptctl/description | ||
| Fscryptctl is mainly intended for embedded systems which can't use the | ||
| full-featured fscrypt tool, or for testing or experimenting with the | ||
| kernel interface to Linux filesystem encryption. fscryptctl does not | ||
| handle key generation, key stretching, key wrapping, or PAM integration. | ||
| Most users should use the fscrypt tool instead, which supports these | ||
| features and generally is much easier to use. | ||
|
|
||
| As fscryptctl is intended for advanced users, you should read the | ||
| kernel documentation for filesystem encryption before using fscryptctl. | ||
|
|
||
| A limitation of fscryptctl is that is has no support for passphrases | ||
| and works only with cryptographic keys. If you need support for | ||
| passphrases, use fscrypt instead of this tool. | ||
| endef | ||
|
|
||
| MAKE_FLAGS += \ | ||
| CFLAGS="$(TARGET_CFLAGS)" \ | ||
| LDFLAGS="$(TARGET_LDFLAGS)" | ||
|
Comment on lines
+42
to
+44
There was a problem hiding this comment. Can you elaborate why this is needed? What is going wrong when you remove this line? I would expect CFLAGS und LDFLAGS to be already set to TARGET_CFLAGS and TARGET_LDFLAGS by MAKE_VARS |
||
|
|
||
| define Package/fscryptctl/install | ||
| $(INSTALL_DIR) $(1)/usr/bin | ||
| $(INSTALL_BIN) $(PKG_BUILD_DIR)/fscryptctl $(1)/usr/bin/ | ||
|
Comment on lines
+46
to
+48
There was a problem hiding this comment. I think you can define this as |
||
| endef | ||
|
|
||
| $(eval $(call BuildPackage,fscryptctl)) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- a/Makefile | ||
| +++ b/Makefile | ||
| @@ -133,7 +133,7 @@ test-all: | ||
|
|
||
| # Installation, uninstallation, and cleanup targets | ||
|
|
||
| -all:fscryptctl fscryptctl.1 | ||
| +all:fscryptctl | ||
|
Comment on lines
+7
to
+8
There was a problem hiding this comment. I think you do not need to keep maintaining this patch if you set |
||
|
|
||
| .PHONY: all install install-bin install-man uninstall clean | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this Makefile need a license, similar to other package Makefiles in this repo? (SPDX line)