fscryptctl: add new package #25716
fscryptctl: add new package #25716
Conversation
Fscryptctl is mainly intended for embedded systems which can't use the full-featured fscrypt tool, or for testing or experimenting with the kernel interface to Linux filesystem encryption. This could be a better option vs fscrypt when use cases are on embedded devices since it is more light-weight. Upstream url: https://github.com/google/fscrypt/blob/master/README.md Build system: x86/64 Build-tested: bcm27xx/bcm2712 Run-tested: bcm27xx/bcm2712 Signed-off-by: John Audia <therealgraysky@proton.me>
|
I will test and review tomorrow |
| PKG_SOURCE_URL:=https://codeload.github.com/google/$(PKG_NAME)/tar.gz/v$(PKG_VERSION)? | ||
| PKG_HASH:=192e25733006b05592fd87038a3a51a014db22f462ce0b24d47c30e66d03ea2c | ||
|
|
||
| PKG_LICENSE:=Apache |
There was a problem hiding this comment.
Apache-2.0. See https://spdx.org/licenses/
|
|
||
| PKG_LICENSE:=Apache | ||
| PKG_LICENSE_FILES:=LICENSE | ||
| PKG_CPE_ID:=cpe:/a:google:fscryptctl |
There was a problem hiding this comment.
Where did you get this CPE Id from? I cannot find it at https://nvd.nist.gov/products/cpe/search
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://codeload.github.com/google/$(PKG_NAME)/tar.gz/v$(PKG_VERSION)? |
There was a problem hiding this comment.
Is the trailing ? intentional? If so, what is it for?
| CATEGORY:=Utilities | ||
| SUBMENU:=Encryption | ||
| TITLE:=A tool that handles keys and manages policies for Linux filesystem encryption | ||
| URL:='https://github.com/google/fscryptctl' |
| MAKE_FLAGS += \ | ||
| CFLAGS="$(TARGET_CFLAGS)" \ | ||
| LDFLAGS="$(TARGET_LDFLAGS)" |
There was a problem hiding this comment.
Can you elaborate why this is needed? What is going wrong when you remove this line? I would expect CFLAGS und LDFLAGS to be already set to TARGET_CFLAGS and TARGET_LDFLAGS by MAKE_VARS
| define Package/fscryptctl/install | ||
| $(INSTALL_DIR) $(1)/usr/bin | ||
| $(INSTALL_BIN) $(PKG_BUILD_DIR)/fscryptctl $(1)/usr/bin/ |
There was a problem hiding this comment.
I think you can define this as
define Package/fscryptctl/install
$(call Build/Install/Default,install-bin)
endef
| -all:fscryptctl fscryptctl.1 | ||
| +all:fscryptctl |
There was a problem hiding this comment.
I think you do not need to keep maintaining this patch if you set MAKE_FLAGS := fscryptctl in the Makefile instead.
| @@ -0,0 +1,51 @@ | |||
| include $(TOPDIR)/rules.mk | |||
There was a problem hiding this comment.
Does this Makefile need a license, similar to other package Makefiles in this repo? (SPDX line)
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://codeload.github.com/google/$(PKG_NAME)/tar.gz/v$(PKG_VERSION)? |
There was a problem hiding this comment.
I agree with #25706 (comment), better not use the variable in the URL
Fscryptctl is mainly intended for embedded systems which can't use the full-featured fscrypt tool, or for testing or experimenting with the kernel interface to Linux filesystem encryption.
This could be a better option vs fscrypt when use cases are on embedded devices since it is more light-weight.
Upstream url: https://github.com/google/fscrypt/blob/master/README.md
Build system: x86/64
Build-tested: bcm27xx/bcm2712
Run-tested: bcm27xx/bcm2712
Maintainer: me