pkg/controller/statusmanager: Link docs.redhat.com #2512
Conversation
docs.openshift.com is being folded into docs.redhat.com. There will hopefully be a redirect system that takes folks from an old-location page straight to the new-location page. But 4.16 has support through 2027-06-27 [1], so point straight at the new location, which protects us against buggy or imprecise redirect implementations (e.g. we don't want customers dropped into the top-level 4.16 welcome page, or anything like that). This patch will obviously only affect new 4.16.z releases; older 4.16.z will still point at docs.openshift.com, and will rely on the redirects or the tenacity of the cluster admin to work around a buggy or imprecise redirect. And if redirects end up being great, we won't have needed this code change. But with the redirect system currently untestable, it seems better to be cautious and avoid it as much as we can. [1]: https://access.redhat.com/support/policy/updates/openshift#dates
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
force-pushed
the
docs.redhat.com-sdn-migration-uri
branch
from
1530993 to
6c694eb
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -379,7 +379,7 @@ func (status *StatusManager) set(reachedAvailableLevel bool, conditions ...operv | |||
| Reason: "OpenShiftSDNConfigured", | |||
| Message: "Cluster is configured with OpenShiftSDN, which is not supported in the next version. Please " + | |||
| "follow the documented steps to migrate from OpenShiftSDN to OVN-Kubernetes in order to be able to upgrade. " + | |||
| "https://docs.openshift.com/container-platform/4.16/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html", | |||
| "https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/ovn-kubernetes-network-plugin", | |||
There was a problem hiding this comment.
Thanks for the PR!
I think the link should point to:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/ovn-kubernetes-network-plugin#migrate-from-openshift-sdn
instead of the generic:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/ovn-kubernetes-network-plugin.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
docs.openshift.com is being folded into docs.redhat.com. There will hopefully be a redirect system that takes folks from an old-location page straight to the new-location page. But 4.16 has support through 2027-06-27, so point straight at the new location, which protects us against buggy or imprecise redirect implementations (e.g. we don't want customers dropped into the top-level 4.16 welcome page, or anything like that). This patch will obviously only affect new 4.16.z releases; older 4.16.z will still point at docs.openshift.com, and will rely on the redirects or the tenacity of the cluster admin to work around a buggy or imprecise redirect. And if redirects end up being great, we won't have needed this code change. But with the redirect system currently untestable, it seems better to be cautious and avoid it as much as we can.