Skip to content

Commit

Permalink
pkg/controller/statusmanager: Link docs.redhat.com
Browse files Browse the repository at this point in the history
docs.openshift.com is being folded into docs.redhat.com.  There will
hopefully be a redirect system that takes folks from an old-location
page straight to the new-location page.  But 4.16 has support through
2027-06-27 [1], so point straight at the new location, which protects
us against buggy or imprecise redirect implementations (e.g. we don't
want customers dropped into the top-level 4.16 welcome page, or
anything like that).  This patch will obviously only affect new 4.16.z
releases; older 4.16.z will still point at docs.openshift.com, and
will rely on the redirects or the tenacity of the cluster admin to
work around a buggy or imprecise redirect.  And if redirects end up
being great, we won't have needed this code change.  But with the
redirect system currently untestable, it seems better to be cautious
and avoid it as much as we can.

[1]: https://access.redhat.com/support/policy/updates/openshift#dates
  • Loading branch information
wking committed Sep 26, 2024
1 parent 5e5e21a commit 6c694eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/controller/statusmanager/status_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ func (status *StatusManager) set(reachedAvailableLevel bool, conditions ...operv
Reason: "OpenShiftSDNConfigured",
Message: "Cluster is configured with OpenShiftSDN, which is not supported in the next version. Please " +
"follow the documented steps to migrate from OpenShiftSDN to OVN-Kubernetes in order to be able to upgrade. " +
"https://docs.openshift.com/container-platform/4.16/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html",
"https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/ovn-kubernetes-network-plugin",
},
)
} else {
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/statusmanager/status_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ func TestStatusManager_set_OpenShiftSDN(t *testing.T) {
Reason: "OpenShiftSDNConfigured",
Message: "Cluster is configured with OpenShiftSDN, which is not supported in the next version. Please " +
"follow the documented steps to migrate from OpenShiftSDN to OVN-Kubernetes in order to be able to upgrade. " +
"https://docs.openshift.com/container-platform/4.16/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html",
"https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/networking/ovn-kubernetes-network-plugin",
}
status.set(true, condNoProgress, condAvailable)

Expand Down

0 comments on commit 6c694eb

Please sign in to comment.