feat: improve range reduction algorithm

src/OpenSpaceToolkit/Physics/Units/Derived/Angle.cpp

@@ -1,4 +1,5 @@
 /// Apache License 2.0
+#include <cmath>
 
 #include <OpenSpaceToolkit/Core/Error.hpp>
 #include <OpenSpaceToolkit/Core/Utilities.hpp>
@@ -61,7 +62,7 @@ bool Angle::operator==(const Angle& anAngle) const
     {
         return false;
     }
-
+    
     switch (unit_)
     {
         case Angle::Unit::Radian:
@@ -356,7 +357,7 @@ Real Angle::in(const Angle::Unit& aUnit) const
         return this->accessValue();
     }
 
-    return this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit);
+    return (this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit));
 }
 
 Real Angle::inRadians() const
@@ -732,24 +733,20 @@ Real Angle::ReduceRange(const Real& aValue, const Real& aRangeLowerBound, const
             "Lower bound [{}] greater than or equal to upper bound [{}].", aRangeLowerBound, aRangeUpperBound
         );
     }
+    // this line handles some rounding error albeit in a way that doesnt pass the smell test...
+    Real value = aValue + 10.0 - 10.0;
+    const Real excessValue = std::fmod(value - aRangeLowerBound, aRangeUpperBound - aRangeLowerBound);
+    const Real adjustedRangeValue = aRangeLowerBound + excessValue;
 
-    Real value = aValue;
-
-    const Real range = aRangeUpperBound - aRangeLowerBound;
-
-    while (value < aRangeLowerBound
-    )  // [TBM] This is a STUPID implementation: just used as a logic placeholder... should be improved ASAP
+    if ((adjustedRangeValue >= aRangeLowerBound) && (adjustedRangeValue < aRangeUpperBound))
     {
-        value += range;
+        return adjustedRangeValue;
     }
-
-    while (value >= aRangeUpperBound
-    )  // [TBM] This is a STUPID implementation: just used as a logic placeholder... should be improved ASAP
-    {
-        value -= range;
-    }
-
-    return value;
+    // Addition here might seem unintuitive, but this edge case is specifically
+    // to capture when excessValue is a different sign than the range (often
+    // a negative value in a positive range) and we are actually adding a
+    // negative number to the upper bound.
+    return aRangeUpperBound + excessValue;
 }
 
 }  // namespace units