feat: improve range reduction algorithm #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all angle tests locally
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 79.86% 79.88% +0.02%
==========================================
Files 93 93
Lines 7448 7447 -1
==========================================
+ Hits 5948 5949 +1
+ Misses 1500 1498 -2
|
| @@ -1,5 +1,5 @@ | |||
| /// Apache License 2.0 | |||
|
|
|||
| #include <cmath> | |||
There was a problem hiding this comment.
Simply for consistency:
Suggested change
| #include <cmath> | |
| #include <cmath> | |
|
|
||
| const Real range = aRangeUpperBound - aRangeLowerBound; | ||
| const Real excessValue = std::fmod(aValue - aRangeLowerBound, aRangeUpperBound - aRangeLowerBound); | ||
| const Real adjestedRangeValue = aRangeLowerBound + excessValue; |
There was a problem hiding this comment.
Suggested change
| const Real adjestedRangeValue = aRangeLowerBound + excessValue; | |
| const Real adjustedRangeValue = aRangeLowerBound + excessValue; |
|
|
||
| while (value < aRangeLowerBound | ||
| ) // [TBM] This is a STUPID implementation: just used as a logic placeholder... should be improved ASAP | ||
| if ((adjestedRangeValue >= aRangeLowerBound) && (adjestedRangeValue < aRangeUpperBound)) |
There was a problem hiding this comment.
Suggested change
| if ((adjestedRangeValue >= aRangeLowerBound) && (adjestedRangeValue < aRangeUpperBound)) | |
| if ((adjustedRangeValue >= aRangeLowerBound) && (adjustedRangeValue < aRangeUpperBound)) |
| { | ||
| value += range; | ||
| return adjestedRangeValue; |
There was a problem hiding this comment.
Suggested change
| return adjestedRangeValue; | |
| return adjustedRangeValue; |
|
|
||
| while (value >= aRangeUpperBound | ||
| ) // [TBM] This is a STUPID implementation: just used as a logic placeholder... should be improved ASAP | ||
| else |
There was a problem hiding this comment.
No need for an else block, since the if block returns.
| { | ||
| value -= range; | ||
| /*/ |
There was a problem hiding this comment.
Comment block style is likely different from the rest of the codebase?
vishwa2710
commented
Oct 11, 2023
| @@ -61,7 +62,7 @@ bool Angle::operator==(const Angle& anAngle) const | |||
| { | |||
| return false; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| @@ -356,7 +357,7 @@ Real Angle::in(const Angle::Unit& aUnit) const | |||
| return this->accessValue(); | |||
| } | |||
|
|
|||
| return this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit); | |||
| return (this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit)); | |||
There was a problem hiding this comment.
Suggested change
| return (this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit)); | |
| return this->accessValue() * Angle::SIRatio(unit_) / Angle::SIRatio(aUnit); |
| @@ -732,24 +733,20 @@ Real Angle::ReduceRange(const Real& aValue, const Real& aRangeLowerBound, const | |||
| "Lower bound [{}] greater than or equal to upper bound [{}].", aRangeLowerBound, aRangeUpperBound | |||
| ); | |||
| } | |||
| // this line handles some rounding error albeit in a way that doesnt pass the smell test... | |||
| Real value = aValue + 10.0 - 10.0; | |||
There was a problem hiding this comment.
Suggested change
| Real value = aValue + 10.0 - 10.0; | |
| const Real value = aValue + 10.0 - 10.0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.