-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move validation test suite, phpstan to GitHub Workflows #386
base: main
Are you sure you want to change the base?
Conversation
6060b96
to
b07595b
Compare
70cd20b
to
89f263b
Compare
This is ready for review, no other changes are planned
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for doing this!
# -u Fail for undefined variables | ||
set -xeu | ||
# This installs and runs phpstan | ||
# TODO: Remove separate phpstan install step after https://github.com/microsoft/tolerant-php-parser/pull/385 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged 385 and removed a merge conflict with main, do you want to remove this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This separate step can be removed now though right?
85ad200
to
a4dcca3
Compare
- Perform a shallow clone of submodules analyzed in validation test suite in GitHub workflows (should take around 30 seconds) - Switch badge in README.md to GitHub Workflows and update default branch for badge. - Remove travis config - After microsoft#385 is merged run_phpstan.sh can remove the separate install step (as a followup PR) - Require a newer phpunit patch version in devDependencies Make it harder for contributors to have any inconsistencies with CI when running tests (e.g. php version support, fixed phpunit bugs, etc)
a4dcca3
to
edc8352
Compare
I undid the changes to php versions in github actions to avoid conflicts with https://github.com/microsoft/tolerant-php-parser/pull/406/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3 and updated composer.json again Unit tests and validation steps aren't run until the workflow run is approved https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
It looks like phpstan ran out of memory
|
if that's the only issue it can be fixed with |
test suite in GitHub workflows (should take around 30 seconds)
branch for badge.
step (as a followup PR)
Make it harder for contributors to have any inconsistencies with CI
when running tests (e.g. php version support, fixed phpunit bugs, etc)