Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Travis CI checks to GitHub workflows #407

Open
TysonAndre opened this issue Dec 26, 2023 · 2 comments
Open

Migrate Travis CI checks to GitHub workflows #407

TysonAndre opened this issue Dec 26, 2023 · 2 comments

Comments

@TysonAndre
Copy link
Contributor

https://app.travis-ci.com/github/Microsoft/tolerant-php-parser/builds is apparently a blank page and broken image at the time this issue was created.

This seems to be why https://github.com/microsoft/tolerant-php-parser/pull/405/files was created

The same functionality is possible (e.g. also run it in docker similar to how phpunit tests are run in GH Actions) if configuration is added (and tested)
@roblourens
Copy link
Member

You started this awhile back in #386, should I merge that?

@TysonAndre
Copy link
Contributor Author

You started this awhile back in #386, should I merge that?

Yes. PHPStan may have had some updates that would cause failures due to dead code (seen locally), which #406 would fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @TysonAndre