tidy all files and fix critic violations

.gitignore

@@ -1,21 +1,21 @@
-*.komodoproject
-*.kpf
-*.sqlite*
-*.sw*
-.DS_Store
-.tidyall.d
 /MYMETA.*
 /Makefile
 /Makefile.old
 /blib
 /cover_db/
-/etc/metacpan_local.pl
 /local/
 /log4perl_local.conf
 /metacpan_server_local.conf
 /perltidy.LOG
 /pm_to_blib
+/var
+/etc/metacpan_local.pl
 /t/var/darkpan/
 /t/var/log/
 /t/var/tmp/
-/var
+*.komodoproject
+*.kpf
+*.sqlite*
+*.sw*
+.DS_Store
+.tidyall.d

.perlcriticrc

@@ -5,16 +5,15 @@ verbose = 11
 theme = core
 
 [-ControlStructures::ProhibitPostfixControls]
-[-Documentation::RequirePodLinksIncludeText]
 [-Documentation::RequirePodSections]
 [-InputOutput::ProhibitInteractiveTest]
 [-Modules::RequireVersionVar]
 [-RegularExpressions::RequireDotMatchAnything]
 [-RegularExpressions::RequireExtendedFormatting]
 [-RegularExpressions::RequireLineBoundaryMatching]
 [-Subroutines::ProhibitExplicitReturnUndef]
+[-TestingAndDebugging::ProhibitNoStrict]
 [-ValuesAndExpressions::ProhibitNoisyQuotes]
-[-ValuesAndExpressions::ProhibitAccessOfPrivateData]
 [-Variables::ProhibitPunctuationVars]
 
 [CodeLayout::RequireTrailingCommas]

bin/convert_authors.pl

@@ -1,3 +1,4 @@
+#!/usr/bin/env perl
 # PODNAME: foo
 
 use strict;

bin/mirror_cpan_for_developers.pl

@@ -1,3 +1,4 @@
+#!/usr/bin/env perl
 # This script is only needed if you are developing metacpan,
 # on the live servers we use File::Rsync::Mirror::Recent
 # https://github.com/metacpan/metacpan-puppet/tree/master/modules/rrrclient

bin/unlisted_prereqs.pl

@@ -5,10 +5,10 @@
 
 use strict;
 use warnings;
-use Perl::PrereqScanner 1.014;
-use CPAN::Meta::Requirements ();
-use File::Find::Rule::Perl;
-use List::Util qw( sum );
+use Perl::PrereqScanner 1.014 ();
+use CPAN::Meta::Requirements  ();
+use File::Find::Rule::Perl    ();
+use List::Util                qw( sum );
 use version 0.77;
 
 # TODO: use CPAN::Meta::Prereqs

etc/metacpan.pl

@@ -1,6 +1,6 @@
 # do not edit this file
 # create etc/metacpan_local.pl instead
-use FindBin;
+use FindBin ();
 
 {
     # ElasticSearch instance, can be either a single server

improve-search-results/.gitignore

@@ -1,2 +1,2 @@
-# carton/local::lib
 /local/
+# carton/local::lib

lib/MetaCPAN/Server/Controller/Login.pm

@@ -29,7 +29,7 @@ sub auto : Private {
 sub index : Path {
     my ( $self, $c ) = @_;
     my @login = map { "<li><a href=\"/login/" . lc($_) . "\">$_</a></li>" }
-        sort grep {s/^Login:://} $c->controllers;
+        sort map /^Login::(.*)/, $c->controllers;
     $c->res->content_type('text/html');
     $c->res->body(qq{<pre><h1>Login via</h1><ul>@login</ul></pre>});
 }

perlimports.toml

@@ -10,7 +10,7 @@
 # preserve_unused disabled.
 
 cache                           = false # setting this to true is currently discouraged
-ignore_modules                  = ["Catalyst::Runtime","Module::Pluggable", "namespace::clean", "Test::More", "Type::Library", "With::Roles"]
+ignore_modules                  = ["Catalyst::Runtime","Module::Pluggable", "namespace::clean", "Test::More", "Type::Library", "With::Roles", "File::Find::Rule::Perl"]
 ignore_modules_filename         = ""
 ignore_modules_pattern          = "" # regex like "^(Foo|Foo::Bar)"
 ignore_modules_pattern_filename = ""

t/lib/MetaCPAN/Server/Test.pm

@@ -3,9 +3,9 @@ package MetaCPAN::Server::Test;
 use strict;
 use warnings;
 
-use HTTP::Request::Common qw( DELETE GET POST );
+use HTTP::Request::Common qw( DELETE GET POST );    ## no perlimports
 use MetaCPAN::Server      ();
-use Plack::Test           qw( test_psgi );
+use Plack::Test           qw( test_psgi );          ## no perlimports
 use Test::More;
 
 use base 'Exporter';

tidyall.ini

@@ -60,8 +60,5 @@ ignore = lib/MetaCPAN/Server/View/Pod.pm
 ignore = lib/MetaCPAN/Util.pm
 ignore = lib/Plack/Session/Store/ElasticSearch.pm
 
-[SortLines]
-select = .gitignore
-
 [UniqueLines]
 select = .gitignore