tidy all files and fix critic violations #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyn
previously approved these changes
Sep 8, 2024
The tests are currently only applied to a subset of files, but in the future we will be using precious against all files. Remove gitignore sorting from the tidyall config. It uses a different sorting algorithm than what we will be using in the future with precious. Once we fully transition to precious, the order will be checked again. But for now it isn't a high priority.
We require modules to use strict. Using no strict is already a signal that we are doing something abnormal, and generally doesn't have any alternatives. This would force disabling strict, then silencing the critic rule about disabling strict. Needing a second signal for the same thing is pointless.
haarg
force-pushed
the
haarg/tidy-critic-all
branch
from
17da6f8 to
85a623b
Compare
mickeyn
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings all files in line with the defined tidy and critic rules using
precious. Some files aren't currently being checked by the tests, which are still usingtidyall.