chore(client): remove price tolerance at the client #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
from
ddd0f45 to
f05d0a4
Compare
bochaco
approved these changes
Oct 11, 2023
bochaco
force-pushed
the
RemoveAPIIndirectionAtClient
branch
from
f05d0a4 to
9e356b3
Compare
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
from
9e356b3 to
f01202c
Compare
reviewpad
bot
added
Medium
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
3 times, most recently
from
71b60c0 to
ac4094e
Compare
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
5 times, most recently
from
a7d16ee to
a0aa382
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Ok(r) => r, | ||
| // any error here will result in a repayment of the register | ||
| // TODO: be smart about this and only pay for storage if we need to |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
2 times, most recently
from
f442278 to
7b77c7b
Compare
This should no longer be needed with repayments reusing existing payments This also removes some client indirection
Remove payment which makes upload valid, instead only pay 0 tokens and that's it.
BREAKING CHANGE: updates client register creation APIs
joshuef
force-pushed
the
RemoveAPIIndirectionAtClient
branch
from
bc0cb8d to
7ceb986
Compare
…notes" This reverts commit 9eb32bb.
| @@ -205,6 +207,8 @@ | |||
| all_data_payments: BTreeMap<XorName, Vec<(MainPubkey, NanoTokens)>>, | |||
| verify_store: bool, | |||
| ) -> WalletResult<NanoTokens> { | |||
| // TODO: | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should no longer be needed with repayments reusing existing payments
This also removes some client indirection## Description
Summary generated by Reviewpad on 11 Oct 23 07:55 UTC
This pull request includes two patches.
The first patch removes the price tolerance at the client and some client indirection. The
get_store_costs_at_addressmethod is removed from theClientstruct, as it is no longer needed with repayments reusing existing payments.The second patch ensures that only the closest nodes are used for pricing. The
get_closest_peersmethod now limits the number of close nodes toCLOSE_GROUP_SIZEand sorts the close nodes based on their distance to the record address before truncating the list. This ensures that only the closest nodes are used for pricing calculations.