fix(node): move reward test calc before storecost check for better co…

…nsistency

sn_node/tests/nodes_rewards.rs

@@ -50,6 +50,7 @@ async fn nodes_rewards_for_storing_chunks() -> Result<()> {
 
     println!("Paying for {} random addresses...", chunks.len());
 
+    let prev_rewards_balance = current_rewards_balance()?;
     let cost = wallet_client
         .pay_for_storage(
             chunks
@@ -59,7 +60,6 @@ async fn nodes_rewards_for_storing_chunks() -> Result<()> {
         )
         .await?;
 
-    let prev_rewards_balance = current_rewards_balance()?;
     let expected_rewards_balance = prev_rewards_balance
         .checked_add(cost)
         .ok_or_else(|| eyre!("Failed to sum up rewards balance"))?;
@@ -87,6 +87,10 @@ async fn nodes_rewards_for_storing_registers() -> Result<()> {
     let owner_pk = client.signer_pk();
     let register_addr = XorName::random(&mut rng);
 
+    // check the rewards balance before paying for the storage
+    // this avoids issues if the balance changed before the storage was paid
+    let prev_rewards_balance = current_rewards_balance()?;
+
     let cost = wallet_client
         .pay_for_storage(
             std::iter::once(NetworkAddress::RegisterAddress(RegisterAddress::new(
@@ -97,7 +101,6 @@ async fn nodes_rewards_for_storing_registers() -> Result<()> {
         )
         .await?;
 
-    let prev_rewards_balance = current_rewards_balance()?;
     let expected_rewards_balance = prev_rewards_balance
         .checked_add(cost)
         .ok_or_else(|| eyre!("Failed to sum up rewards balance"))?;