Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled and adjusted functionality of the Travel info modals #467

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ZaredRogers
Copy link
Contributor

@ZaredRogers ZaredRogers commented Jan 7, 2025

Description

The Travel Information modals required some styling and some added functionality to close on outside click and escape key.

Solutions

Styling

Styling changes were added to the style.css and _modals.scss files

  • A radius of 6px was added to the Travel information modal
  • A border of 3px was added, in the primary colour of the theme
  • Padding was adjusted on the content and close button

Functionality

Functionality changes were added to custom.js file

  • A click event listener was added to close when a user clicks outside the modal
  • A key event listener was added to close the modal when the esc key is pressed

Zambia-–-Tour-Operator-DBA--01-07-2025_04_55_PM

@ZaredRogers ZaredRogers requested a review from krugazul January 7, 2025 14:52
@ZaredRogers ZaredRogers self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Image description CodeRabbit


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between d20c491 and 400bd1e commits.
Files selected (3)
  • assets/css/scss/_modals.scss (1)
  • assets/css/style.css (1)
  • assets/js/src/custom.js (1)
Files not summarized due to errors (3)
  • assets/js/src/custom.js (diff tokens exceeds limit)
  • assets/css/style.css (nothing obtained from openai)
  • assets/css/scss/_modals.scss (nothing obtained from openai)
Files not reviewed due to errors (2)
  • assets/css/style.css (no response)
  • assets/css/scss/_modals.scss (no response)
Files skipped from review due to trivial changes (1)
  • assets/js/src/custom.js (diff too large)
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@krugazul krugazul merged commit 8ab6e71 into 2.0.1-update Jan 7, 2025
4 of 5 checks passed
@krugazul krugazul deleted the travel-info-modal-styling branch January 7, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parent: Tour Operator Blocks Read more block variation - Open Modals
2 participants