Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read more block variation - Open Modals #368

Closed
2 of 4 tasks
Tracked by #361 ...
ashleyshaw opened this issue Oct 9, 2024 · 1 comment · Fixed by #438, #465, #467, #461 or #457
Closed
2 of 4 tasks
Tracked by #361 ...

Read more block variation - Open Modals #368

ashleyshaw opened this issue Oct 9, 2024 · 1 comment · Fixed by #438, #465, #467, #461 or #457
Assignees
Labels
[Component] Block Variations Block development issues or pulls. [Status] Needs Design Needs design efforts. [Status] Needs More Info Follow-up required in order to be actionable. [Type] Feature New feature to highlight in changelogs
Milestone

Comments

@ashleyshaw
Copy link
Member

ashleyshaw commented Oct 9, 2024

Description:

Create a variation of the Paragraph block that allows the ability to be truncated after a specified number of words. This block will need to work for the Description of the single posts at the top of the page, which will have a Read More link that users can click to unfold the rest of the description below. This will also need to be used for the Travel Information blocks, however these will open up popup modals with the rest of the information when the View More button on the card is clicked using Popup Maker.

Use Cases:

  1. Single Post Description Section:

    • For descriptions that are quite long, this block will display a truncated version initially.
    • The block will include a "Read More" link that, when clicked, expands the remaining text below.
  2. Travel Information Blocks:

    • The Travel Information blocks will use a similar truncated view, but instead of expanding inline, it will display a "View More" button.
    • When clicked, this button will open a popup containing the full content of the description.

Requirements:

  • Add a control to the block sidebar for setting the maximum number of words before truncation.
  • Implement two variations:
    • "Read More" link for inline expansion (Single Post Description Section).
    • "View More" button for a popup expansion (Travel Information Blocks).
  • Add styling options for both inline and popup views to ensure consistent UI/UX with the design specifications.

Design Notes:

Refer to the provided screenshots for visual guidance on how the "Read More" and "View More" interactions should appear.

Screenshots

Description Read More closed

Image

Description Read More open

Image

Travel Info blocks closed

Image

Travel Info blocks open

Image

Acceptance Criteria:

  • Block truncates at the specified word count.
  • "Read More" link successfully expands text inline.
  • "View More" button opens a popup with the remaining text for Travel Information blocks.
  • Styling aligns with design screenshots.
@ashleyshaw ashleyshaw added [Status] Needs Design Needs design efforts. [Type] Feature New feature to highlight in changelogs [Status] Needs More Info Follow-up required in order to be actionable. [Component] Block Variations Block development issues or pulls. labels Oct 9, 2024
@ashleyshaw ashleyshaw added this to the 2.0.0 milestone Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Tour Operator Oct 9, 2024
@ashleyshaw ashleyshaw moved this from Needs Triage to 📥 Todo in Tour Operator Oct 9, 2024
This was referenced Oct 12, 2024
@krugazul krugazul moved this from 📥 Needs Dev to 🏗️ In Progress in Tour Operator Oct 23, 2024
@ZaredRogers ZaredRogers linked a pull request Nov 11, 2024 that will close this issue
@krugazul krugazul changed the title Read more block variation for tours, accommodation and destination archive templates Read more block variation - Open Modals Dec 5, 2024
@krugazul
Copy link
Collaborator

krugazul commented Dec 5, 2024

The various sections handle the read more block, and has been tested. The opening of the modals will need to wait for version 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment