Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gazebo Simulation for Kuka LBR iisy 3 R760 #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jacob-kruse
Copy link

Before submitting this PR into master please make sure:

If you added a new robot model:

  • you extended the table of verified data in README.md with the new model
  • you extended the CMakeLists.txt of the appropriate moveit configuration package with the new model
  • you added a test_<robot_model>.launch.py and after launching the robot was visible in rviz
  • you added a <robot_model>_joint_limits.yaml file in the config directory (to provide moveit support)

If you modified an already existing robot model:

  • you checked and optionally updated the table of verified data in README.md with the changes
  • you have run the test_<robot_model>.launch.py and the robot was visible in rviz

Short description of the change

Added a Gazebo Launch and Gazebo URDF with macros for Gazebo Simulation with the Kuka LBR iisy 3 R760

Note: Inertial values in the gazebo_macro were required for Gazebo. These values are just placeholders and not accurate by any means.

@jacob-kruse jacob-kruse requested a review from Svastits as a code owner December 6, 2024 14:29
@Svastits
Copy link
Member

Thanks for your contribution :)
We do not have a policy yet for gazebo urdf, launch and config files, so we might take some time to consider the most optimal structure for that to minimize code duplication and maximize the user experience.

is the controller_manager node not necessary? the controllers cannot be spawned and therefore I can not see the robot neither in rviz, nor in gazebo

@jacob-kruse
Copy link
Author

jacob-kruse commented Dec 20, 2024

The controller_manager node is not necessary because Gazebo has its own controller manager. When I run the launch file, the controllers spawn correctly, I see the robot in both RViz and Gazebo, and I am able to motion plan.

I tried the launch without the controller spawners and did not see the URDF's, so I am assuming there is some issue with the Gazebo controller manager in your situation. @Svastits

Make sure you have ros-jazzy-gz-ros2-control installed for the control plugin and all the Gazebo simulation packages installed. The commands below should install these.

sudo apt install ros-jazzy-gz*
sudo apt install ros-jazzy-ros-gz*

- Created new URDF's for lbr_iisy11_r1300 and lbr_iisy15_930 for Gazebo simulation

- Removed unnecessary arguments from Launch file

- Fixed formatting issues
@jacob-kruse
Copy link
Author

I fixed the formatting issues in my most recent commit. I also implemented the lbr_iisy11_r1300 and lbr_iisy15_r930 for Gazebo simulation. I have tested these models and I am able to motion plan in Gazebo with both additions.

In response to your earlier point about code organization, it might be good to make a folder for Gazebo simulation. This folder could store the launch file, configuration files, and Gazebo macros. The URDF's I added are essentially the same, I only added inertial values and calls to the Gazebo hardware and Gazebo control plugins. At some point the original URDF files can be modified and passed an argument for Gazebo simulation to call the macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants