Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-build-isolation
to pip install (previously added by default due to lack of pyproject.toml)It seems like this might be a nicer way to interact with cmake for Python packages, rather than custom setuptools commands, which seem to be on the way out for compiled code.
Only downside I see is that
--no-build-isolation
becomes a required arg, so you don't get any benefit frombuild-system.requires
, as those dependencies don't get installed automatically.I think it could be possible to build without disabling isolation by identifying the parent process to run the
${Python_EXECUTABLE}
steps with instead of the default interpreter. I don't know of a robust way to do that, though.