Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt scikit-build-core #67

Closed
wants to merge 2 commits into from
Closed

adopt scikit-build-core #67

wants to merge 2 commits into from

Conversation

minrk
Copy link
Collaborator

@minrk minrk commented Jun 5, 2023

  • remove setup.py
  • requires --no-build-isolation to pip install (previously added by default due to lack of pyproject.toml)

It seems like this might be a nicer way to interact with cmake for Python packages, rather than custom setuptools commands, which seem to be on the way out for compiled code.

Only downside I see is that --no-build-isolation becomes a required arg, so you don't get any benefit from build-system.requires, as those dependencies don't get installed automatically.

I think it could be possible to build without disabling isolation by identifying the parent process to run the ${Python_EXECUTABLE} steps with instead of the default interpreter. I don't know of a robust way to do that, though.

@minrk minrk marked this pull request as draft June 5, 2023 11:59
- remove setup.py
- requires `--no-build-isolation` to pip install (previously added by default due to lack of pyproject.toml)
@jorgensd
Copy link
Owner

jorgensd commented Jun 5, 2023

Agreed, this looks really nice! Thanks for the effort

@jorgensd
Copy link
Owner

Superseeded by #91

@jorgensd jorgensd closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants