Scikit-build allow build isolation #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove setup.py - requires `--no-build-isolation` to pip install (previously added by default due to lack of pyproject.toml)
no idea how reliable this is
|
As DOLFINx has adopted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experiment on #67 where
--no-build-isolationis no longer required.The parent sys.executable is located by inspecting the
$_environment variable, which seems pretty sketchy. I don't think it's a good idea, but this or something similar may be worth exploring?Note that everything 'normal' (e.g. pybind11) still uses the isolated build environment. But the two calls to get paths out of Python imports use the parent Python instead of the isolated env.
Very much a 'works for me' experiment and illustration that should probably be closed. I'm mainly curious to see if it works on CI.